-
Notifications
You must be signed in to change notification settings - Fork 1
chore: fix path #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix path #12
Conversation
- enhance cutout url construction for different environments - use local proxy in development for header injection and cors avoidance - fallback to relative path if external endpoint is not configured - construct url for external endpoint if available
- add slcomp logo to the left of the title - add github link to the right of the filters - update styling for better visual appeal
|
Caution Review failedThe pull request is closed. WalkthroughUpdates the dashboard header to include a left-aligned SLComp logo and a right-aligned GitHub link, applied in normal and loading states. Adjusts cutout URL construction and dev/prod control flow in api.ts: absolute URL fallback without RAW_ENDPOINT, earlier DEV short-circuit in getCutoutObject, and maintained proxy behavior. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant UI as UI Component
participant API as getCutoutObject
participant BCU as buildCutoutUrl
participant NET as Network
participant CACHE as Blob Cache
UI->>API: getCutoutObject(objectKey)
API->>BCU: buildCutoutUrl(objectKey)
BCU-->>API: url
alt DEV mode
note over API: DEV short-circuit
API-->>UI: url (proxy-served)
else Production
API->>CACHE: check blob cache
alt Cache hit
CACHE-->>API: blobUrl
API-->>UI: blobUrl
else Cache miss
API->>NET: fetch(url)
alt Fetch success
NET-->>API: blob
API->>CACHE: store blob, createObjectURL
API-->>UI: blobUrl
else Fetch failure
NET-->>API: error
API-->>UI: url (direct)
end
end
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary by CodeRabbit
New Features
Style
Bug Fixes