Skip to content

changing defaults for Double & Boolean #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sateesh-kadiyala-procore wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

changing defaults for Double & Boolean #237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/resultset.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,8 @@ ResultSet.prototype.toObjectIter = function (callback) {
var dateVal = self._rs[getter](cmd.label);
result[cmd.label] = dateVal ? dateVal.toString() : null;
} else {
// If the column is an integer and is null, set result to null and continue
if (type === 'Int' && _.isNull(self._rs.getObjectSync(cmd.label))) {
// If the column is an integer or Double or Boolean and is null, set result to null and continue
if ((type === 'Int' || type === 'Double' || type === 'Boolean') && _.isNull(self._rs.getObjectSync(cmd.label))) {
result[cmd.label] = null;
return;
}
Expand Down