Add SNBT serialisation #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if I'm honest, this should already be complete. I have also added unit tests. Every unit test is matching against actual SNBT produced by Minecraft (1.21.1)* * actually, 1.21.1 doesn't allow nameless compound values yet, so I had to manually add those in (c. compound_with_basic_numbers and others)
I would rather we could keep them, but that would mean making escape_string_value and its module public
Norbiros
requested changes
Oct 28, 2025
Member
Norbiros
left a comment
Norbiros
left a comment
There was a problem hiding this comment.
Overall, pretty good job! Sorry for the delay, but I was away from home for a while.
Contributor
Author
|
Not sure what happened there... will investigate tomorrow |
Contributor
Author
|
Finally figured out how to run Clippy and formatter. Should be fine now |
Contributor
Author
|
okay, I don't think I've done anything to cause that. Compiled and tested perfectly fine on my machine too can someone else have a look at that log? |
Member
|
Sorry for the delay. Yeah, it wasn't your fault - it was a change introduced in recent versions of clippy. I fixed this issue in 8e0cd21, so please, just rebase your branch on top of |
Norbiros
approved these changes
Nov 2, 2025
(just update your branch, so our checks can run)
Contributor
Author
|
it is done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the various Nbt types only implement
std::fmt::Debug, which displays the internal structure and is very hard to read. A more readable format (for non-debugging purposes) would be to format the data as SNBT, completing one half of #32 in so doing.As such, I have implemented
std::fmt::DisplayonNbt,NbtTag, andNbtCompound, which produces valid SNBT matching the formatting used by Minecraft. I have also added various unit tests that match, again, the output produced by CrabNBT with real Minecraft SNBT output.Following the SNBT standard ensures a lossless representation of the data, moreover one that is easily machine parsable. This opens up the possibility of implementing
std::str::FromStrin the future, which would also handily complete the other side of #32.