Skip to content

Conversation

@kievan
Copy link

@kievan kievan commented Jul 23, 2019

  • add custom Configuration dependency injection
  • relevant files code clean up and style
  • tests passing

@kievan
Copy link
Author

kievan commented Jul 23, 2019

Hi @Kern046,

Since I see no way to make the build happy - either tests will fail with php 7.0, or php 7.2, I thought a forward looking decision is to exclude the php 7.0 version and use the phpunit >= 7.

If I missed a way to fix tests in a way that would satisfy php 7.0, 7.1 and 7.2 please point it out.

Thanks

@Kern046
Copy link
Collaborator

Kern046 commented Mar 4, 2020

Hi,

I deeply apologize for my silence, it has been a very busy year for me and it's only the beginning !

I plan to make a refacto of this library to allow easier custom implementations, I'll keep you updated about it ! I need to get myself back in to make the best decisions about PHP versions support and the correct way to implement proper patterns in the library, but I'll take some time to do it in the next few days.

Sorry once again for the late response, and thanks for your PR !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants