-
-
Notifications
You must be signed in to change notification settings - Fork 39
Secure 1024-bit seed feature generation #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: ver/1.21.8
Are you sure you want to change the base?
Conversation
|
I use this with world generation datapacks, it doesn't break them. I have tested it with big world generation datapacks such as Terralith and Incendium, and it works just fine. I actually used Folia in the past and switched to the 1024 bit feature generation without issues. |
|
I will do further testing of this PR later and a proper review. Thank you for ur submission, Ill try and get it done sometime today |
|
This PR, the Luminol patch, it is fully based off the Leaf patch? I am asking because I did find a discussion in the leaf discord that regards this patch that does alter world generation, so I am currently unsure about this given currently it is said that the issue in reference happens on all versions of Leaf, meaning if Luminols is a 1:1 port, it most likely has this issue too. https://discord.com/channels/1145991395388162119/1379560713642704967 |
|
It is, yes. To me, it seems like a reasonable compromise in exchange for a secure seed (no way for hacked clients to bypass antixray for example, by knowing the server's seed) My suggestion would be to add this option disabled by default, along with a disclaimer that it may cause minor visual changes to biome borders.... |
|
Yea ATM, despite it being a small issue, I would infact like this issue to be resolved, I think Leaf and Luminol would too. If this issue can be resolved, Ill probably merge the PR |
This ports Luminol (Leaf)'s secure feature seed implementation. Added a setting to enable feature/structure RNG that uses 1024‑bit seed while terrain/biomes remain tied to the normal 64‑bit world seed.
This is useful to prevent seed cracking.
Added
"secureSeed": falsesetting to the config./seedshows 1024-bit feature seed when secure seed is enabled.Original patch implementation is by @MrHua269 in Luminol, feature is originally from Leaf.