'Skip visual tests' QUnit option #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0gr
reviewed
Dec 1, 2018
| '/visual-test-output' | ||
| )).then(() => this.insertIntoFile( | ||
| 'tests/test-helper.js', | ||
| `import setupVisualTests from 'ember-visual-test/test-support/setup';`, |
There was a problem hiding this comment.
I think a simpler approach would be just to import a vendor file with QUnit customizations. You can see how it's done in the ember-qunit addon https://github.com/emberjs/ember-qunit/blob/6877684cb3b8c960ebbe06b2f58dfde0243f2b8f/index.js#L21.
Contributor
Author
There was a problem hiding this comment.
Oh, that's much simpler. Nice, thanks 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've got a project which has a lot of visual tests. I do need them, but not always - sometimes I'd like to skip them to test things faster. So here I've added a QUnit checkbox that allows you to skip all visual tests - they will pass without performing actual tests.