ci: harden CI workflows with environment-based protection #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Convert 10 workflows from pull_request_target to pull_request trigger - Create 3 reusable workflows with centralized test logic: - reusable-molecule-test-linux.yml - reusable-molecule-test-windows.yml - reusable-container-sensor-pull.yml - Add environment protection (molecule-testing) for PR secret access - Update actions/checkout to v5.0.1 (SHA pinned) - Fix psscriptanalyzer action pinning from main to v1.1 - Add CODEOWNERS file with falcon-scripts-cs-maintainers Security improvements: - Eliminates pull_request_target risks from fork PRs - Environment approval gates secret access for external contributors - All actions properly SHA-pinned with version comments - PR SHA passed explicitly to prevent confusion attacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR hardens CI workflows against supply chain attacks by replacing
pull_request_targetwith environment-based secret gating.Security Improvements
pull_request_targetattack surface - Removed from 10 workflows that were vulnerable to malicious fork PRsgithub.event.pull_request.head.shaexplicitlyThis ensures:
FALCON_CLIENT_IDetc. without maintainer approvalFiles Changed
New Reusable Workflows
.github/workflows/reusable-molecule-test-linux.yml- Linux molecule testing.github/workflows/reusable-molecule-test-windows.yml- Windows molecule testing.github/workflows/reusable-container-sensor-pull.yml- Container sensor pullModified Caller Workflows (10 total)
bash_install.yml,bash_install_decrement.yml,bash_install_only.yml,bash_install_policy.yml,bash_migrate.ymlpwsh_install_ccid.yml,pwsh_install_policy.yml,pwsh_migrate.yml,pwsh_uninstall.ymlcontainer_sensor_pull.ymlOther Hardening
docs.yml,psscriptanalyzer.yml,release.yml,shell_format.yml,shellcheck.yml,stale.yml