Conversation
benthongtiang
added
the
patch
Contributor
Lighthouse Performance ReportMetrics📄Full Report |
johnny-hausman
requested changes
Feb 16, 2026
Collaborator
johnny-hausman
left a comment
johnny-hausman
left a comment
There was a problem hiding this comment.
The code itself looks good.
Again, make sure the kitchen sink tests pass and then this should be good to go.
Also, it seems like your editor isn't running eslint + prettier when you save your files. Try to get it to do that as all the spacing in this file hasn't been updated by prettier.
if you can't get your editor to do that automatically, then run $npm run lint in the project directory.
…n/TextPlugin (Resolve conflict in index.js)
johnny-hausman
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CruGlobal/appbuilder_class_core#329