Refactor call of ABApplication.viewNew() to match .pageNew() and similar methods

ABApplicationCore.js

@@ -994,12 +994,14 @@ module.exports = class ABApplicationCore extends ABMLClass {
    /**
     * @method viewNew()
     *
-    * return an instance of a new (unsaved) ABView.
+    * return an instance of a new (unsaved) ABView tied to this ABApplication.
     *
+    * @param {object} values  view definition/settings
+    * @param {ABView} [parent=null]  parent view of the new view
     * @return {ABView}
     */
-   viewNew(values, application, parent) {
-      return this.ViewManager.newView(values, application, parent);
+   viewNew(values, parent = null) {
+      return this.ViewManager.newView(values, this, parent);
    }
 
    ///

ABFactoryCore.js

@@ -1076,7 +1076,7 @@ class ABFactory extends EventEmitter {
       if (!this._mockApp) {
          this._mockApp = this.applicationNew({});
       }
-      return this._mockApp.viewNew(values, this._mockApp);
+      return this._mockApp.viewNew(values, null);
    }
 
    //

mobile/ABMobilePageCore.js

@@ -351,7 +351,7 @@ module.exports = class ABMobilePageCore extends ABMobileView {
       // NOTE: this returns a new ABView component.
       // when creating a new page, the 3rd param should be null, to signify
       // the top level component.
-      var page = this.application.viewNew(values, this.application, null);
+      var page = this.application.viewNew(values, null);
       page.parent = this;
       return page;
    }

mobile/ABMobileViewCore.js

@@ -67,11 +67,7 @@ module.exports = class ABMobileViewCore extends ABMLClass {
     */
    static newInstance(application, parent) {
       // return a new instance from ABViewManager:
-      return application.viewNew(
-         { key: this.common().key },
-         application,
-         parent
-      );
+      return application.viewNew({ key: this.common().key }, parent);
    }
 
    viewKey() {
@@ -210,7 +206,7 @@ module.exports = class ABMobileViewCore extends ABMLClass {
       (values.viewIDs || []).forEach((id) => {
          var def = this.AB.definitionByID(id);
          if (def) {
-            views.push(this.application.viewNew(def, this.application, this));
+            views.push(this.application.viewNew(def, this));
          } else {
             this.__missingViews.push(id);
          }
@@ -552,12 +548,8 @@ module.exports = class ABMobileViewCore extends ABMLClass {
     * @method viewNew()
     * @return {ABView}
     */
-   viewNew(values, application, parent) {
-      return this.application.viewNew(
-         values,
-         application || this.application,
-         parent || this
-      );
+   viewNew(values, parent) {
+      return this.application.viewNew(values, parent || this);
    }
 
    /**
@@ -811,7 +803,7 @@ module.exports = class ABMobileViewCore extends ABMLClass {
       }
 
       // copy from settings
-      let result = this.viewNew(config, this.application, parent);
+      let result = this.viewNew(config, parent);
 
       // change id
       if (parent == null) {
@@ -885,7 +877,7 @@ module.exports = class ABMobileViewCore extends ABMLClass {
       }
 
       // copy from settings
-      let result = this.application.viewNew(config, this.application, parent);
+      let result = this.application.viewNew(config, parent);
 
       // keep the parent
       result.parent = parent || this.parent;

views/ABViewConditionalContainerCore.js

@@ -31,7 +31,6 @@ module.exports = class ABViewConditionalContainerCore extends ABViewContainer {
                   removable: false,
                },
             },
-            application,
             this
          );
 
@@ -47,7 +46,6 @@ module.exports = class ABViewConditionalContainerCore extends ABViewContainer {
                   removable: false,
                },
             },
-            application,
             this
          );
 

views/ABViewCore.js

@@ -67,11 +67,7 @@ module.exports = class ABViewCore extends ABMLClass {
     */
    static newInstance(application, parent) {
       // return a new instance from ABViewManager:
-      return application.viewNew(
-         { key: this.common().key },
-         application,
-         parent
-      );
+      return application.viewNew({ key: this.common().key }, parent);
    }
 
    viewKey() {
@@ -214,7 +210,7 @@ module.exports = class ABViewCore extends ABMLClass {
       (values.viewIDs || []).forEach((id) => {
          var def = this.AB.definitionByID(id);
          if (def) {
-            views.push(this.application.viewNew(def, this.application, this));
+            views.push(this.application.viewNew(def, this));
          } else {
             this.__missingViews.push(id);
          }
@@ -555,15 +551,10 @@ module.exports = class ABViewCore extends ABMLClass {
    /**
     * @method viewNew()
     *
-    *
     * @return {ABView}
     */
-   viewNew(values, application, parent) {
-      return this.application.viewNew(
-         values,
-         application || this.application,
-         parent || this
-      );
+   viewNew(values, parent) {
+      return this.application.viewNew(values, parent || this);
    }
 
    /**
@@ -805,7 +796,7 @@ module.exports = class ABViewCore extends ABMLClass {
       }
 
       // copy from settings
-      let result = this.viewNew(config, this.application, parent);
+      let result = this.viewNew(config, parent);
 
       // change id
       if (parent == null) {
@@ -879,7 +870,7 @@ module.exports = class ABViewCore extends ABMLClass {
       }
 
       // copy from settings
-      let result = this.application.viewNew(config, this.application, parent);
+      let result = this.application.viewNew(config, parent);
 
       // keep the parent
       result.parent = parent || this.parent;

views/ABViewLayoutCore.js

@@ -41,7 +41,6 @@ module.exports = class ABViewLayoutCore extends ABViewWidget {
             {
                key: ABViewContainer.common().key,
             },
-            this.application,
             this
          )
       );

views/ABViewPageCore.js

@@ -322,7 +322,7 @@ module.exports = class ABViewPageCore extends ABViewContainer {
       // NOTE: this returns a new ABView component.
       // when creating a new page, the 3rd param should be null, to signify
       // the top level component.
-      var page = this.application.viewNew(values, this.application, null);
+      var page = this.application.viewNew(values, null);
       page.parent = this;
       return page;
    }

views/ABViewTabCore.js

@@ -67,7 +67,6 @@ module.exports = class ABViewTabCore extends ABViewWidget {
                label: tabName,
                tabicon: tabIcon,
             },
-            this.application,
             this
          )
          .save();