Skip to content

Consolidate some Circuit logic#4326

Merged
frett merged 16 commits intodevelopfrom
circuitActivity
Feb 16, 2026
Merged

Consolidate some Circuit logic#4326
frett merged 16 commits intodevelopfrom
circuitActivity

Conversation

@frett
Copy link
Contributor

@frett frett commented Feb 16, 2026

No description provided.

@frett frett changed the title Consolidate some Circuit config Consolidate some Circuit logic Feb 16, 2026
@frett frett marked this pull request as draft February 16, 2026 15:48
frett and others added 5 commits February 16, 2026 10:56
Centralizes the Circuit hosting boilerplate (inject Circuit, enableEdgeToEdge,
CircuitCompositionLocals, GodToolsTheme, NavigableCircuitContent) into a single
activity that accepts an initial Screen via intent extra.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@codecov
Copy link

codecov bot commented Feb 16, 2026

Codecov Report

❌ Patch coverage is 76.63043% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.45%. Comparing base (6b89ec6) to head (d5eefa7).
⚠️ Report is 17 commits behind head on develop.

Files with missing lines Patch % Lines
...rg/cru/godtools/base/ui/circuit/CircuitActivity.kt 0.00% 24 Missing ⚠️
...s/ui/account/delete/DeleteAccountLayout+Preview.kt 0.00% 3 Missing ⚠️
...cru/godtools/ui/languages/app/AppLanguageLayout.kt 57.14% 0 Missing and 3 partials ⚠️
.../godtools/ui/account/delete/DeleteAccountLayout.kt 77.77% 0 Missing and 2 partials ⚠️
...lin/org/cru/godtools/ui/drawer/DrawerMenuLayout.kt 0.00% 2 Missing ⚠️
...godtools/ui/languages/LanguageSettingsPresenter.kt 83.33% 0 Missing and 2 partials ⚠️
.../godtools/ui/account/delete/DeleteAccountScreen.kt 0.00% 1 Missing ⚠️
...ols/ui/languages/LanguageSettingsDeepLinkParser.kt 88.88% 0 Missing and 1 partial ⚠️
...ru/godtools/ui/languages/LanguageSettingsLayout.kt 98.80% 0 Missing and 1 partial ⚠️
...ru/godtools/ui/languages/LanguageSettingsModule.kt 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4326      +/-   ##
===========================================
+ Coverage    46.43%   46.45%   +0.02%     
===========================================
  Files          436      436              
  Lines        11770    11764       -6     
  Branches      2038     2046       +8     
===========================================
  Hits          5465     5465              
+ Misses        5720     5714       -6     
  Partials       585      585              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

frett and others added 4 commits February 16, 2026 14:32
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…tivity

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@frett frett marked this pull request as ready for review February 16, 2026 19:50
@frett frett merged commit fd4a2d7 into develop Feb 16, 2026
13 checks passed
@frett frett deleted the circuitActivity branch February 16, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments