Conversation
| } | ||
|
|
||
| public function following() | ||
| public function followings() |
There was a problem hiding this comment.
make sure you refactor the places where this function is being called too.
And here
cryptocards/backend/app/Models/User.php
Line 66 in 8fa4742
| @@ -0,0 +1,57 @@ | |||
| import React, { Component } from 'react'; | |||
There was a problem hiding this comment.
I think you could refactor FollowersList.js and FollowingsList.js into 1 component since they are so similar and just pass different data into them, kinda like what we do with Card.js
| return ( | ||
| <div | ||
| key={index} | ||
| className="follower col-lg-3 col-md-5 m-2 animated fadeInUp" |
There was a problem hiding this comment.
I don't think follower is a css class. If you were looking at some of the card code. card is Actually a bootstrap class.
https://getbootstrap.com/docs/4.0/components/card/
You can also use reactstrap to use Card as an element instead of a class
https://reactstrap.github.io/components/card/
| </Link> | ||
| </div> | ||
| </div> | ||
| <div className="follower-body"> |
There was a problem hiding this comment.
follower-body is not a class
| </div> | ||
| </div> | ||
| <div className="follower-body"> | ||
| <h5 className="follower-title text-center"> |
There was a problem hiding this comment.
follower-title is not a class
frontend/src/App.js
Outdated
| {/*Routes that only logged in Users can access*/} | ||
| <UserRoute path="/useronly" component={Debug} /> | ||
| <UserRoute path="/account" component={AccountPage} /> | ||
| <UserRoute path="/followers/:id" component={FollowersPage} /> |
There was a problem hiding this comment.
If we are only going to display the followers and followings on the Account page, I don't think we need routes.
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
============================================
- Coverage 23.58% 23.11% -0.47%
- Complexity 133 135 +2
============================================
Files 91 92 +1
Lines 1463 1510 +47
Branches 188 193 +5
============================================
+ Hits 345 349 +4
- Misses 1042 1085 +43
Partials 76 76
Continue to review full report at Codecov.
|
bbemis017
left a comment
bbemis017
left a comment
There was a problem hiding this comment.
Everything looks good, but I don't think email.html was meant to be on this one.
frontend/src/email.html
Outdated
| @@ -0,0 +1,39 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
I think you meant to have this file on your other branch?
3 participants
Still need to figure out the db relationships for followers and followings