Delay lock inits #235
Open
Delay lock inits #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FasterSpeeding
commented
Feb 12, 2023
| """ | ||
|
|
||
| __slots__ = ("_authors", "_buffer", "_index", "_iterator", "_lock") | ||
| __slots__ = ("_authors", "_buffer", "_index", "_iterator") |
Collaborator
Author
There was a problem hiding this comment.
Todo: how does locking work for components when multiple ppl are using them and do we need to bring back these locks?
Contributor
|
FasterSpeeding
force-pushed
the
task/fix-locks
branch
3 times, most recently
from
f51aafc to
3c6eaf3
Compare
FasterSpeeding
force-pushed
the
task/fix-locks
branch
from
3c6eaf3 to
16f16f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
noxand all the pipelines have passed.Related issues