Skip to content

Comments

contact us form css changes#19

Open
jaspreet-android wants to merge 4 commits intomasterfrom
contact_form_changes
Open

contact us form css changes#19
jaspreet-android wants to merge 4 commits intomasterfrom
contact_form_changes

Conversation

@jaspreet-android
Copy link

No description provided.

@jorgeolmos
Copy link
Collaborator

jorgeolmos commented Mar 3, 2020

Please work on the following items in order to make this PR merge ready:

  • When opening the contact form, Name field should be focused, so the user can start typing from there.
  • Email field should have a * to denote it's a mandatory field.
  • Email field error should be inline, and not a notification at the bottom of the modal dialog.
  • When Email field doesn't validate, in addition to showing the error as stated in the line above, that field should be focused.
  • We'll never share your email with anyone else. legend should be in a lighter color and smaller font.
  • When the user touches the X or outside the dialog form, the form should be reset, this means that the next time the form is opened it shouldn't contain any previous data, this includes the We will be in touch shortly, thank you! notification or some validation / submission error after form submission.
  • When the user submits the dialog, a loading spinner or disabling the submit button text and displaying processing in it should be done in order o avoid duplicate submission and to let the user know that the form has been sent and we are processing it, visual feedback basically.
  • Change We will be in touch shortly, thank you! notification background color, current lime color is really annoying, let's use green but not that bright.

@jorgeolmos jorgeolmos self-requested a review March 3, 2020 14:33
Copy link
Collaborator

@jorgeolmos jorgeolmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the above comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants