use buildPath to make a portable path#41
Open
John-Colvin wants to merge 1 commit intoCyberShadow:masterfrom
Open
use buildPath to make a portable path#41John-Colvin wants to merge 1 commit intoCyberShadow:masterfrom
John-Colvin wants to merge 1 commit intoCyberShadow:masterfrom
Conversation
John-Colvin
force-pushed
the
proper_path
branch
from
66c0877 to
7369fa7
Compare
CyberShadow
requested changes
Oct 13, 2019
Owner
CyberShadow
left a comment
CyberShadow
left a comment
There was a problem hiding this comment.
Does this address any problem in practice or is this a purely cosmetic change?
|
|
||
| @property override string[] requiredExecutables() { return ["dmd"]; } | ||
| @property override string[] binPaths() { return ["dmd2/" ~ platformDir ~ "/bin" ~ modelString]; } | ||
| @property override string[] binPaths() { return [buildPath("dmd2", platformDir, "bin", modelString)]; } |
Owner
There was a problem hiding this comment.
"bin", modelString should be "bin" ~ modelString.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.