Skip to content

adding fix for q greater than 1 test #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
llondon6 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

adding fix for q greater than 1 test #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions phenom/testing/prec_angle_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,9 @@ def evaluate_phenomPv2_angles(flist, m1, m2, s1x, s1y, s1z, s2x, s2y, s2z, fref,

q = m1 / m2

if q < 1.:
# Allow for margin where q may be less than ben still very close to 1. This is useful when inputting masses from NR.
if (abs(q-1)<1e-3): q = 1.0
if q<1.0 :
raise(ValueError("mass-ratio < 1. m1 must be the larger black hole"))

# the angles are functions of dimensionless orbital angular GW frequency
Expand All @@ -114,4 +116,3 @@ def evaluate_phenomPv2_angles(flist, m1, m2, s1x, s1y, s1z, s2x, s2y, s2z, fref,
beta.data[i] = PhenomPBeta(f, q, chip, chi1l)

return alpha.data, beta.data, epsilon.data