build openjpeg with -DCMAKE_BUILD_TYPE=Release#9
Open
kaczmarj wants to merge 1 commit intoCzaki:masterfrom
Open
build openjpeg with -DCMAKE_BUILD_TYPE=Release#9kaczmarj wants to merge 1 commit intoCzaki:masterfrom
kaczmarj wants to merge 1 commit intoCzaki:masterfrom
Conversation
This commit adds the option `-DCMAKE_BUILD_TYPE=Release` to the openjpeg build. Without this, ffast-math is not enabled and results in slower performance. Related to discussion in Bayer-Group/tiffslide#72 (comment), where we found performance differences between tiffslide and openslide. Dziekuje :)
Author
|
This change breaks functionality -- tests fail. I will look into why this is, but I assume it's due to fast-math. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds the option
-DCMAKE_BUILD_TYPE=Releaseto the openjpeg build. Without this, ffast-math is not enabled and results in slower performance.Related to discussion in Bayer-Group/tiffslide#72 (comment), where we found performance differences between tiffslide and openslide.
Dziekuje :)