refactor(intro): introduce state management for introduction pages#87
Open
AndreasPopel wants to merge 7 commits intoDARC-e-V:devfrom
Open
refactor(intro): introduce state management for introduction pages#87AndreasPopel wants to merge 7 commits intoDARC-e-V:devfrom
AndreasPopel wants to merge 7 commits intoDARC-e-V:devfrom
Conversation
App Version 1.0.6
For an easier entry to develop on this project, some screens have been reworked to use components instead of repeatedly nested widgets. Furthermore, magic numbers for course identifications have been broken up into constant based enums, while respecting the possible course types. The handling for setting up the course selection has been centralized in order to improve maintainability. Some occurences for future improvements have been marked with a TODO flag.
The onboarding process (referenced as welcome) has been converted to bloc state management. Furthermore some ui elements habe been improved and reworked.
A previous version of flutter_math_fork needed to be pinned in order for builds to work properly.
chore(pubspec): pin previous version of flutter_math_fork
Contributor
Author
|
Updated screenshots, colors have been reverted to the original styles. "Neu" badge for course class N has been removed. 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to previous PR #83 the introduction of the user in the app has been reworked. Some graphics have been adjusted, optimized and also tested in dark mode.
Furthermore a BLOC has been used as the state management for this workflow, including the required events and state abstractions. This handles initial setting of the required course as well als changes afterwards.
See screenshots below for the improved onboarding: