Skip to content

fix users being able to bypass selecting background region #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MrMondrian wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix users being able to bypass selecting background region #274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions source/pixel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,6 +665,16 @@ export default class PixelPlugin
case this.tools.type.grab:
mouseClickDiv.style.cursor = "-webkit-grab";
break;
case this.tools.type.select:
if(this.selection !== null && this.selection.selectedShape !== null) {
let rectangle = this.selection.selectedShape;
//if the rectangle has 0 area, then the user just clicked and should be
//interpreted as a command to remove the current selection
if(rectangle.relativeRectHeight === 0 && rectangle.relativeRectWidth === 0) {
this.selection.clearSelection(this.core.getSettings().maxZoomLevel);
}
}
break;
default:
}
}
Expand Down