optional notarization step #511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dromer
force-pushed
the
feature/macos-notarization
branch
from
1f4624a to
8d7f88f
Compare
falkTX
reviewed
Oct 28, 2025
falkTX
reviewed
Oct 28, 2025
dromer
force-pushed
the
feature/macos-notarization
branch
from
82b26a8 to
28dcb4e
Compare
Contributor
Author
|
@falkTX I added an explainer comment on the logs. anything else? |
Contributor
|
No, this is fine. I thought the PR was still marked as draft. Let's merge then, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
something like this? (will test it in CI first)