Skip to content

Fix LADSPA hint calculation for logarithmic parameters #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sboukortt wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −3
Open

Fix LADSPA hint calculation for logarithmic parameters #512

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions distrho/src/DistrhoPluginLADSPA+DSSI.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@

#include "DistrhoPluginInternal.hpp"

#include <cmath>

#if DISTRHO_PLUGIN_WANT_PARAMETER_VALUE_CHANGE_REQUEST
# error Cannot use parameter value change request with LADSPA or DSSI
#endif
Expand Down Expand Up @@ -646,9 +648,21 @@ static const struct DescriptorInitializer
portRangeHints[port].HintDescriptor |= LADSPA_HINT_DEFAULT_MAXIMUM;
else
{
const float middleValue = ranges.min/2.0f + ranges.max/2.0f;
const float middleLow = (ranges.min/2.0f + middleValue/2.0f)/2.0f + middleValue/2.0f;
const float middleHigh = (ranges.max/2.0f + middleValue/2.0f)/2.0f + middleValue/2.0f;
float middleValue;
float middleLow;
float middleHigh;
if (hints & kParameterIsLogarithmic)
{
middleValue = std::sqrt(ranges.min * ranges.max);
middleLow = std::sqrt(std::sqrt(ranges.min * middleValue) * middleValue);
middleHigh = std::sqrt(std::sqrt(ranges.max * middleValue) * middleValue);
}
else
{
middleValue = ranges.min/2.0f + ranges.max/2.0f;
middleLow = (ranges.min/2.0f + middleValue/2.0f)/2.0f + middleValue/2.0f;
middleHigh = (ranges.max/2.0f + middleValue/2.0f)/2.0f + middleValue/2.0f;
}

/**/ if (defValue < middleLow)
portRangeHints[port].HintDescriptor |= LADSPA_HINT_DEFAULT_LOW;
Expand Down