MoistAir entropy and isentropicExponent issue#172
MoistAir entropy and isentropicExponent issue#172RaphaelGebhart wants to merge 3 commits intoDLR-SR:mainfrom
Conversation
…oistAir.specificEntropy and added 3 Test Models for further discussion
dzimmer
left a comment
dzimmer
left a comment
There was a problem hiding this comment.
Looks good for me by reading through it. I have to test the code though yet. No complaints so far.
tobolar
changed the title
|
What is the reason for this being a draft? I would otherwise go on with the regression test |
|
I think jakub suggested the PR to be a draft, because i called the package "MoistAirDiscussion" and wrote "I assume" and "I suggest" in the docu, since im no expert in the media model but just noticed some issues at saturation where the media model retuns not reasonable results without warning the user, and maybe also since we said we might want to tell the MSL directly. |
nieweber
added
priority::high
|
I’ve transferred this issue to the Modelica Standard Library for discussion: Let’s wait for their feedback and recommendations. This aligns well with our plans anyway, as we are intending to switch back to |
|
In OpenModelica v1.26.1 the warning is ussed once. In Dymola 2024x Refresh 1 it is issued at every function call. @CorentinLepais can you check |
|
In Dymola 2025x and Dymola 2026x the is issued 4 times in total. |
4 participants
Added assert(relativeHumidty<=1) to MoistAir.isentropicExponent and MoistAir.specificEntropy and added 3 Test Models for further discussion closes #169