Implement isobaric expansion coefficient for incompressible media#245
Open
AxelMatstoms wants to merge 1 commit intoDLR-SR:mainfrom
Open
Implement isobaric expansion coefficient for incompressible media#245AxelMatstoms wants to merge 1 commit intoDLR-SR:mainfrom
AxelMatstoms wants to merge 1 commit intoDLR-SR:mainfrom
Conversation
Update Incompressible.TableBased with implementation for isobaric expansion coefficient (beta). The value is given by (1 / V) * (dV/dT), where V is the specific volume (V=1/rho) and T is the temperature. dV/dT is found by using the chain rule and the derivative of the polynomial fitting for rho.
Collaborator
|
Yes you’re welcome to create an issue at MSL GitHub :) I couldn’t find any component in the TFS that currently uses it, so we can also quickly discuss what you would require it for :). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Incompressible.TableBased with implementation for isobaric expansion coefficient (beta). The value is given by$$\frac{1}{\nu}\frac{d\nu}{dT}$$ , where $\nu$ is the specific volume ($\nu=\frac{1}{\rho}$ ) and T is the temperature. $\frac{d\nu}{dT}$ is found by using the chain rule and the derivative of the polynomial fitting for rho. Previously, TableBased media inherited the partial definition from PartialMedium, which meant the property had no implementation.
This problem is "inherited" from the MSL Media library, so I'm not sure if it would be better to make the changes to the MSL first, then synchronize our copy of the Media library.