Skip to content

Conversation

@steven-bellock
Copy link
Contributor

Fix #3419 and enforce strict DER checks.

Fix DMTF#3419 and enforce strict DER checks.

Signed-off-by: Steven Bellock <sbellock@nvidia.com>
sizeof(basic_constraints_false_case)))) {
return true;
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm reading commit a9e42b0 correctly, then it appears this would trigger a "false"/failure of any existing/previous deployed leaf certificate with the Basic Constraints OID's CA:FALSE (len!=sizeof(basic_constraints_false_case fallout case), which libspdm_verify_leaf_cert_basic_constraints() used to pass.

Could the empty CA:FALSE check be made optional for SPDM Requesters that choose to handle this case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the empty CA:FALSE check be made optional for SPDM Requesters that choose to handle this case?

#3164 (comment) proposes to let the Integrator selectively disable specific checks, so when/if that gets implemented then they would be able to disable the Basic Constraints check if they so desire.

@steven-bellock steven-bellock marked this pull request as ready for review December 9, 2025 22:11
@steven-bellock steven-bellock requested a review from jyao1 as a code owner December 9, 2025 22:11
@steven-bellock
Copy link
Contributor Author

Converting to draft while we wait for the SPDM WG.

@steven-bellock steven-bellock marked this pull request as draft December 15, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BASIC_CONSTRAINTS_STRING_FALSE_CASE2 should (probably) not exist

2 participants