Removed tzp variable from gettimeofday function for linux#26
Merged
Daivuk merged 2 commits intoDaivuk:masterfrom Oct 18, 2025
Merged
Removed tzp variable from gettimeofday function for linux#26Daivuk merged 2 commits intoDaivuk:masterfrom
Daivuk merged 2 commits intoDaivuk:masterfrom
Conversation
…ble from gettimeofday for linux
Owner
|
Hi, first of all: thank you so much for the contribution! I had no idea, as I do not use linux. The file you modified is auto generated. Please edit the right header and re-generate the single header using gen_single_header.py |
…r linux and replaced it with NULL
Contributor
Author
|
Thanks for letting me know, I have now changed the code in the source directly rather than just editing the header file. I used the generate python script, and it made a new header with the changes and it also compiles correctly into a test program. It should now be ready to merge! |
Owner
|
Oops all the OSX workflow seem to fail. Probably a cmake version mismatch with latest. I will merge anyway because your changes can't cause this.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On linux its a deprecated feature and adding this change allows for the program to compile.
In the man page for the function: "If tzp is not a null pointer, the behavior is unspecified."