npm install test 워크플로우 구현 #656
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Member
|
@RiaOh 님, PR을 티켓과 연결 부탁드리겠습니다. 보드에 안 나와서 제가 계속 놓치고 있었네요. |
DaleSeo
reviewed
Dec 12, 2025
Comment on lines
+7
to
+8
| branches: [main] | ||
| types: [opened, synchronize, reopened] |
Member
There was a problem hiding this comment.
release -> main PR이 생성되었을때 npm pack 을 사용하여 install 가능 여부 테스트
혹시나 해서 티켓 내용을 보니 이벤트가 잘못 설정되어 있네요. 현재 설정은 base 브랜치가 main으로 잡고 PR을 생성/재성성/변경 때 마다 워크플로우가 실행됩니다. 요구사항대로 구현하려면 push 이벤트를 사용해서 워크플로우 실행 시점을 잡아야할 것 같습니다.
Contributor
Author
There was a problem hiding this comment.
@DaleSeo 님,
install-test:
if: ${{ startsWith(github.head_ref, 'release/') }}
이 코드가 추가되어있어 "release/x.y.z" 에서 main브랜치로 PR생성/커밋 추가 등 업데이트/PR이 재오픈될때 워크플로우가 실행되도록 설정해두었습니다~!
Member
There was a problem hiding this comment.
디폴트라서 불필요합니다.
옷, 이 부분 아직 반영이 안 된 것 같네요.
hyoseong1994
approved these changes
Dec 18, 2025
DaleSeo
reviewed
Dec 20, 2025
| @@ -0,0 +1,125 @@ | |||
| name: NPM Install Test - daleui | |||
Member
There was a problem hiding this comment.
Suggested change
| name: NPM Install Test - daleui | |
| name: NPM Install Test |
Contributor
Author
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경 사항
목적
리뷰어에게
PR 작성자 체크 리스트