This repository was archived by the owner on Apr 25, 2020. It is now read-only.
Issue #727: Don't add .hs-boot modules to context #730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
withInteractiveContext was adding the whole module graph to the interactive context - including .hs-boot modules. This caused each symbol from any .hs-boot to be loaded twice. The .hs-boot files are of no use to us anyway, so this patch filters them out.
Owner
|
I'd be curious to know how ghci handles this. I had a quick look yesterday and I couldn't find any sort of hs-boot specific code before they call setContext there at all. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
withInteractiveContext was adding the whole module graph to the interactive
context - including .hs-boot modules. This caused each symbol from any .hs-boot
to be loaded twice. The .hs-boot files are of no use to us anyway, so this patch
filters them out.