This repository was archived by the owner on Apr 25, 2020. It is now read-only.
Correction on formatted string for Emacs ghc lint #875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielG
reviewed
Mar 2, 2017
| (when los | ||
| (concat "[" | ||
| (mapconcat (lambda (x) (concat "\"" x "\"")) los ", ") | ||
| "]"))) |
Owner
There was a problem hiding this comment.
You know, I honestly didn't know we were already doing some form of escaping here. I think we might have just broken B/C at some point. I'll have to look into that.
Owner
|
Ok, so the first version to break this was v5.3.0.0. Since that's quite a while ago and no one has complained until now I don't think it's worth adding support for that back. Also since this |
Author
|
@DanielG I dont mind. |
|
@lemoce You still alive? :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.