Reset frame time when Composable's lifecycle is resumed #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the delta from the previous frame time til now being so large that we render an inordinate amount of particles, slowing down or even crashing the app by running out of memory. A very similar issue as fixed in: DanielMartinus#289
Contributor
Author
|
Resolves the same issue #341, but I think targets the issue better by solving for the erroneous frame time calculation in the Composable. |
Contributor
Author
|
Build is blocked on #343 |
|
This is much better solution, thanks. |
Owner
|
Thanks for looking into this, and apologies for my inactivity. Appreciate the PRs addressing some of the issues 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the delta from the previous frame time til now being so large that we render an inordinate amount of particles, slowing down or even crashing the app by running out of memory. A very similar issue as fixed in: #289