-
Notifications
You must be signed in to change notification settings - Fork 17
Debugging assignment #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RoberVega
wants to merge
13
commits into
main
Choose a base branch
from
debugging-assignment
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it as an exercise on assignment_2. Added a second part of assignment_2 focused on project structure.
life_expectancy files
out the importance of VSCode shortcuts. Left the design patterns module and assignment for the last week.
assignment timing
Co-authored-by: Fernando <fernando@pluckd.co>
the OOP and Text editors modules.
exercise in assignment_2
its own module and added a debugging sub-exercise on assignment_2
MrCordeiro
suggested changes
Sep 20, 2023
Contributor
MrCordeiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of this PR (sorry!). Here are my reasonings.
- No reason was provided for moving the debugger module out of the Text Editors content. This would also break the structure revision from #26
- The exercise is generic. There's no way for people to validate if it was achieved or not. A better assignment would be to run the tests from the debugger. That would require people to modify
.vscode/launch.json. We could as them to add the instructions on how to debug the tests to theirREADME.md.
Another option would be to simply drop the debugging assignment.
Contributor
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.