Skip to content

Conversation

@RoberVega
Copy link
Contributor

No description provided.

RoberVega and others added 13 commits September 7, 2023 13:25
it as an exercise on assignment_2. Added a second
part of assignment_2 focused on project structure.
out the importance of VSCode shortcuts. Left the
design patterns module and assignment for the last
week.
Co-authored-by: Fernando <fernando@pluckd.co>
the OOP and Text editors modules.
its own module and added a debugging sub-exercise on
assignment_2
@RoberVega RoberVega closed this Sep 19, 2023
@RoberVega RoberVega reopened this Sep 19, 2023
Copy link
Contributor

@MrCordeiro MrCordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of this PR (sorry!). Here are my reasonings.

  • No reason was provided for moving the debugger module out of the Text Editors content. This would also break the structure revision from #26
  • The exercise is generic. There's no way for people to validate if it was achieved or not. A better assignment would be to run the tests from the debugger. That would require people to modify .vscode/launch.json. We could as them to add the instructions on how to debug the tests to their README.md.

Another option would be to simply drop the debugging assignment.

@RoberVega
Copy link
Contributor Author

RoberVega commented Sep 28, 2023

  • The reason for moving the debugging module is simple: we cannot ask students to do an assignment on debuggers before teaching them what a debugger is. I understand that it fits better within the text_editors module although not being exclusively a text editor thing, but timing regarding exercise is more important.
  • Debugging is generic, there no one way to debug, and that is why the exercise is generic, but we can change it into something more specific too. I also think that is a better idea. I am not a fan of your assignment proposal just because it means changing vscode config settings and this adds an extra layer of difficulty. Since running tests from the debugger is not the most common scenario for debugging, I would propose something simpler. I also believe this will stress the importance of debugging. What do you think about writing our own short script, with some incompatibility or issue and ask them to use the debugger first to give an explanation on what the code does (maybe we could even use bad naming conventions to make it harder) and then fix the issue? That way the debugging assignment decouples from our life_expectancy code and we can leave the debugging unit within the text_editor module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants