This repository was archived by the owner on Sep 19, 2024. It is now read-only.
Fix messages with links repeating text#71
Open
MrJeremyFisher wants to merge 1 commit intoDarkKronicle:mainfrom
Open
Fix messages with links repeating text#71MrJeremyFisher wants to merge 1 commit intoDarkKronicle:mainfrom
MrJeremyFisher wants to merge 1 commit intoDarkKronicle:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Messages with links repeat text. Removing the call to io.github.darkkronicle.advancedchatcore.util.TextUtil#replaceStrings fixes this. I don't see any issues with this, but it isn't entirely clear because the documentation regarding the prefilter and aforementioned method call is outdated/incorrect. If removing this method does break something, another possible solution is removing this pre-filter entirely as it makes several assumptions that should be configurable on a case-by-case basis per user.