Merge bitcoin/bitcoin#26294: build: move util/url to common/url#1232
Merge bitcoin/bitcoin#26294: build: move util/url to common/url#1232DashCoreAutoGuix wants to merge 1 commit intobackport-0.25-batch-480from
Conversation
3a0b352 refactor: move url.h/cpp from lib util to lib common (fanquake) 058eb69 build: add missing event cflags to libbitcoin_util (fanquake) Pull request description: Move `util/url` to `common/url`. Also add missing `event_*` flags to `libbitcoin_util`. bitcoin#26293 + the commit dropping boost cppflags from `libbitcoin_util` shows this issue. i.e: ```bash CXX util/libbitcoin_util_a-url.o util/url.cpp:7:10: fatal error: 'event2/http.h' file not found #include <event2/http.h> ^~~~~~~~~~~~~~~ 1 error generated. ``` ACKs for top commit: hebasto: ACK 3a0b352 ryanofsky: Code review ACK 3a0b352 Tree-SHA512: 600a76fd334267a02d332df9b67891a38d3fd7f5baf8a82b2447879b3bc65eab2552d2c081c0a5f1ec927bf80df7fc1f0cbbdda4cb76994b46dadf260b8e1cb3
|
Warning Rate limit exceeded@DashCoreAutoGuix has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 11 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (11)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Backports bitcoin#26294
This commit moves
util/url.handutil/url.cpptocommon/url.handcommon/url.cppas part of Bitcoin's library reorganization.Changes:
src/util/url.{h,cpp}tosrc/common/url.{h,cpp}src/Makefile.amto reflect new file locations$(EVENT_CFLAGS)tolibbitcoin_common_a_CPPFLAGS$(LIBBITCOIN_COMMON)todash_cli_LDADDDash-specific adaptations:
build_msvc/files (not present in Dash)ci/test/06_script_b.sh(not present in Dash)src/wallet/rpc/wallet.cpp(Dash-specific file that references url.h)<stacktraces.h>include insrc/bitcoind.cpp(Dash-specific)Verification:
Original commit: 27e76af