Merge bitcoin/bitcoin#25986: test: refactor RPCPackagesTest to use MiniWallet#1237
Merge bitcoin/bitcoin#25986: test: refactor RPCPackagesTest to use MiniWallet#1237DashCoreAutoGuix wants to merge 1 commit intobackport-0.25-batch-488from
RPCPackagesTest to use MiniWallet#1237Conversation
…let` Backport of bitcoin#25986 Original commit: 00c3236 Refactors RPCPackagesTest to use MiniWallet for transaction creation, and adds create_self_transfer_chain method to MiniWallet class. Removes the no-longer-needed make_chain, create_child_with_parents, and create_raw_chain functions from wallet.py. Note: Removed wtxid references as Dash does not support SegWit. Also excluded test_rbf and test_submitpackage tests as they depend on BIP125 RBF and package relay features.
|
Warning Rate limit exceeded@DashCoreAutoGuix has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 26 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Backport of bitcoin#25986
This PR refactors
RPCPackagesTestto useMiniWalletfor transaction creation, simplifying the test code and making it more maintainable.Changes:
RPCPackagesTestto useMiniWallet.create_self_transfer()andMiniWallet.create_self_transfer_multi()for transaction creationcreate_self_transfer_chain()method toMiniWalletclasssend_self_transfer_chain()method toMiniWalletclassmake_chain,create_child_with_parents, andcreate_raw_chainfunctions fromwallet.pyDash-specific adaptations:
wtxidreferences as Dash does not support SegWittest_rbfandtest_submitpackagetests as they depend on BIP125 RBF and package relay features not present in this versionOriginal Bitcoin PR: bitcoin#25986
Original commit:
00c323610aTest Plan
rpc_packages.pyfunctional test passesMiniWalletcontinue to work