Add boolean check to isEqual function, and adds two other functions#3
Open
MikeCaputo wants to merge 3 commits intoDatZach:masterfrom
Open
Add boolean check to isEqual function, and adds two other functions#3MikeCaputo wants to merge 3 commits intoDatZach:masterfrom
MikeCaputo wants to merge 3 commits intoDatZach:masterfrom
Conversation
Contributor
Author
|
Oops, I'm not sure why it's bringing in all three of these commits, @DatZach . Let me know if you want me to create a new PR. Also, this merge request bundles a couple of different things in, so let me know if you want me to break it up further 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One fix and two new functions
2.3.7.603(https://gms.yoyogames.com/ReleaseNotes.html), I found that a struct with a value oftruewas being evaluated asTruewithin the IDE, whereas before it was evaluated as a1. This was causing Gamemaker to fail, because theisEqualfunction did not have a boolean comparator.i.
indexOf, which returns the index of an item within a collection.ii.
flatArrayIncludes, which can only check flat arrays but is more performant than theincludesfunction.