Skip to content

Conversation

@agent-platform-auto-pr
Copy link
Contributor

Automatically created by merging DataDog/omnibus-software#573
⚠️ This PR is opened with the qa/no-code-change label by default. Please make sure this is appropriate

@agent-platform-auto-pr agent-platform-auto-pr bot requested a review from a team as a code owner March 5, 2025 18:39
@agent-platform-auto-pr agent-platform-auto-pr bot added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/agent-delivery labels Mar 5, 2025
@agent-platform-auto-pr agent-platform-auto-pr bot requested review from a team as code owners March 5, 2025 18:39
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Mar 5, 2025
@agent-platform-auto-pr
Copy link
Contributor Author

[Fast Unit Tests Report]

On pipeline 57834646 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor Author

Uncompressed package size comparison

Comparison with ancestor 7877501df1d24ee2400938dead31bac9d5035309

Size reduction summary
package diff status size ancestor threshold
datadog-agent-x86_64-rpm -0.00MB 824.98MB 824.98MB 0.50MB
datadog-agent-x86_64-suse -0.00MB 824.98MB 824.98MB 0.50MB
Diff per package
package diff status size ancestor threshold
datadog-agent-arm64-deb 0.00MB 806.06MB 806.06MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 815.83MB 815.83MB 0.50MB
datadog-agent-amd64-deb 0.00MB 815.18MB 815.18MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 39.46MB 39.46MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 39.54MB 39.54MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 39.54MB 39.54MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 37.99MB 37.99MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 440.86MB 440.86MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 62.14MB 62.14MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 62.21MB 62.21MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 62.20MB 62.20MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 59.36MB 59.36MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 59.43MB 59.43MB 0.50MB

Decision

✅ Passed

@cit-pr-commenter
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 7e12801e-6bb4-49f1-b726-62651a693788

Baseline: 7877501
Comparison: b27c6f5
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +0.83 [+0.77, +0.89] 1 Logs
quality_gate_idle memory utilization +0.60 [+0.56, +0.64] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.18 [-0.29, +0.66] 1 Logs
quality_gate_idle_all_features memory utilization +0.09 [+0.07, +0.12] 1 Logs bounds checks dashboard
file_tree memory utilization +0.07 [+0.01, +0.13] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.07 [-0.72, +0.85] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.01 [-0.76, +0.78] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.01 [-0.68, +0.70] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.29, +0.30] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.03, +0.04] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.00 [-0.80, +0.80] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.64, +0.62] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.06 [-0.88, +0.76] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.47 [-1.25, +0.31] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -1.06 [-1.96, -0.17] 1 Logs
quality_gate_logs % cpu utilization -1.31 [-4.17, +1.55] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor Author

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 788.93MiB 801.8MiB 192.39MiB 202.62MiB
static_quality_gate_agent_deb_arm64 780.12MiB 793.14MiB 174.45MiB 184.51MiB
static_quality_gate_agent_rpm_amd64 788.82MiB 801.79MiB 194.37MiB 205.03MiB
static_quality_gate_agent_rpm_arm64 780.1MiB 793.09MiB 175.85MiB 186.44MiB
static_quality_gate_agent_suse_amd64 788.8MiB 801.81MiB 194.37MiB 205.03MiB
static_quality_gate_agent_suse_arm64 780.11MiB 793.14MiB 175.85MiB 186.44MiB
static_quality_gate_dogstatsd_deb_amd64 37.71MiB 47.67MiB 9.78MiB 19.78MiB
static_quality_gate_dogstatsd_deb_arm64 36.3MiB 46.27MiB 8.48MiB 18.49MiB
static_quality_gate_dogstatsd_rpm_amd64 37.71MiB 47.67MiB 9.79MiB 19.79MiB
static_quality_gate_dogstatsd_suse_amd64 37.71MiB 47.67MiB 9.79MiB 19.79MiB
static_quality_gate_iot_agent_deb_amd64 59.33MiB 69.0MiB 14.91MiB 24.8MiB
static_quality_gate_iot_agent_deb_arm64 56.69MiB 66.4MiB 12.87MiB 22.8MiB
static_quality_gate_iot_agent_rpm_amd64 59.33MiB 69.0MiB 14.93MiB 24.8MiB
static_quality_gate_iot_agent_rpm_arm64 56.69MiB 66.4MiB 12.87MiB 22.8MiB
static_quality_gate_iot_agent_suse_amd64 59.33MiB 69.0MiB 14.93MiB 24.8MiB
static_quality_gate_docker_agent_amd64 873.57MiB 886.12MiB 293.91MiB 304.21MiB
static_quality_gate_docker_agent_arm64 888.13MiB 900.79MiB 280.13MiB 290.47MiB
static_quality_gate_docker_agent_jmx_amd64 1.05GiB 1.06GiB 369.02MiB 379.33MiB
static_quality_gate_docker_agent_jmx_arm64 1.05GiB 1.06GiB 351.2MiB 361.55MiB
static_quality_gate_docker_dogstatsd_amd64 45.86MiB 55.78MiB 17.3MiB 27.28MiB
static_quality_gate_docker_dogstatsd_arm64 44.47MiB 54.45MiB 16.17MiB 26.16MiB
static_quality_gate_docker_cluster_agent_amd64 265.09MiB 274.78MiB 106.42MiB 116.28MiB
static_quality_gate_docker_cluster_agent_arm64 281.02MiB 290.82MiB 101.22MiB 111.12MiB

@FlorentClarret
Copy link
Member

/merge

@dd-devflow
Copy link

dd-devflow bot commented Mar 6, 2025

View all feedbacks in Devflow UI.
2025-03-06 07:41:36 UTC ℹ️ Start processing command /merge


2025-03-06 07:41:39 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 30m.


2025-03-06 08:22:40 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit ea27c81 into main Mar 6, 2025
286 checks passed
@dd-mergequeue dd-mergequeue bot deleted the automated/omnibus-software/573 branch March 6, 2025 08:22
@github-actions github-actions bot added this to the 7.65.0 milestone Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-delivery

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants