Skip to content

Conversation

@agent-platform-auto-pr
Copy link
Contributor

Automatically created by merging DataDog/omnibus-software#572
⚠️ This PR is opened with the qa/no-code-change label by default. Please make sure this is appropriate

@agent-platform-auto-pr agent-platform-auto-pr bot added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/agent-delivery labels Mar 10, 2025
@agent-platform-auto-pr agent-platform-auto-pr bot requested review from a team as code owners March 10, 2025 14:25
@FlorentClarret
Copy link
Member

/merge

@dd-devflow
Copy link

dd-devflow bot commented Mar 10, 2025

View all feedbacks in Devflow UI.
2025-03-10 14:26:48 UTC ℹ️ Start processing command /merge


2025-03-10 14:27:00 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-03-10 15:25:21 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 33m.


2025-03-10 15:50:47 UTC ℹ️ MergeQueue: This merge request was merged

@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Mar 10, 2025
@agent-platform-auto-pr
Copy link
Contributor Author

[Fast Unit Tests Report]

On pipeline 58277399 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor Author

Uncompressed package size comparison

Comparison with ancestor 73afd53ac371c23232ecd3414139ff503818134b

Diff per package
package diff status size ancestor threshold
datadog-agent-aarch64-rpm 0.00MB 810.57MB 810.56MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 819.59MB 819.59MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 819.59MB 819.59MB 0.50MB
datadog-agent-amd64-deb 0.00MB 809.80MB 809.79MB 0.50MB
datadog-agent-arm64-deb 0.00MB 800.79MB 800.79MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 440.61MB 440.61MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 39.33MB 39.33MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 39.41MB 39.41MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 39.41MB 39.41MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 37.85MB 37.85MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 62.17MB 62.17MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 62.24MB 62.24MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 62.24MB 62.24MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 59.40MB 59.40MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 59.47MB 59.47MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor Author

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 783.3 MiB 801.8 MiB 191.08 MiB 202.62 MiB
static_quality_gate_agent_deb_arm64 774.68 MiB 793.14 MiB 173.43 MiB 184.51 MiB
static_quality_gate_agent_rpm_amd64 783.29 MiB 801.79 MiB 193.15 MiB 205.03 MiB
static_quality_gate_agent_rpm_arm64 774.67 MiB 793.09 MiB 175.41 MiB 186.44 MiB
static_quality_gate_agent_suse_amd64 783.29 MiB 801.81 MiB 193.15 MiB 205.03 MiB
static_quality_gate_agent_suse_arm64 774.67 MiB 793.14 MiB 175.41 MiB 186.44 MiB
static_quality_gate_dogstatsd_deb_amd64 37.58 MiB 47.67 MiB 9.74 MiB 19.78 MiB
static_quality_gate_dogstatsd_deb_arm64 36.18 MiB 46.27 MiB 8.45 MiB 18.49 MiB
static_quality_gate_dogstatsd_rpm_amd64 37.58 MiB 47.67 MiB 9.75 MiB 19.79 MiB
static_quality_gate_dogstatsd_suse_amd64 37.58 MiB 47.67 MiB 9.75 MiB 19.79 MiB
static_quality_gate_iot_agent_deb_amd64 59.36 MiB 69.0 MiB 14.91 MiB 24.8 MiB
static_quality_gate_iot_agent_deb_arm64 56.72 MiB 66.4 MiB 12.88 MiB 22.8 MiB
static_quality_gate_iot_agent_rpm_amd64 59.36 MiB 69.0 MiB 14.94 MiB 24.8 MiB
static_quality_gate_iot_agent_rpm_arm64 56.72 MiB 66.4 MiB 12.87 MiB 22.8 MiB
static_quality_gate_iot_agent_suse_amd64 59.36 MiB 69.0 MiB 14.94 MiB 24.8 MiB
static_quality_gate_docker_agent_amd64 868.43 MiB 886.12 MiB 292.18 MiB 304.21 MiB
static_quality_gate_docker_agent_arm64 883.11 MiB 900.79 MiB 278.51 MiB 290.47 MiB
static_quality_gate_docker_agent_jmx_amd64 1.04 GiB 1.06 GiB 367.28 MiB 379.33 MiB
static_quality_gate_docker_agent_jmx_arm64 1.04 GiB 1.06 GiB 349.59 MiB 361.55 MiB
static_quality_gate_docker_dogstatsd_amd64 45.73 MiB 55.78 MiB 17.24 MiB 27.28 MiB
static_quality_gate_docker_dogstatsd_arm64 44.36 MiB 54.45 MiB 16.12 MiB 26.16 MiB
static_quality_gate_docker_cluster_agent_amd64 264.86 MiB 274.78 MiB 106.29 MiB 116.28 MiB
static_quality_gate_docker_cluster_agent_arm64 280.8 MiB 290.82 MiB 101.13 MiB 111.12 MiB

@cit-pr-commenter
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: bcc74aac-4752-4ac6-a543-6404800c8605

Baseline: 73afd53
Comparison: 9a4840f
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +2.13 [-0.63, +4.89] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.49 [-0.28, +1.27] 1 Logs
quality_gate_idle memory utilization +0.42 [+0.35, +0.48] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization +0.33 [-0.50, +1.16] 1 Logs
quality_gate_idle_all_features memory utilization +0.21 [+0.15, +0.28] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency_http1 egress throughput +0.04 [-0.77, +0.86] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.01 [-0.82, +0.84] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.01 [-0.63, +0.64] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.02] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.29, +0.29] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.69, +0.67] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.02 [-0.87, +0.83] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.09 [-0.88, +0.70] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.45 [-0.90, +0.01] 1 Logs
file_tree memory utilization -0.62 [-0.75, -0.48] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.87 [-0.96, -0.77] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency_http2 lost_bytes 9/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@dd-mergequeue dd-mergequeue bot merged commit 957a31b into main Mar 10, 2025
267 of 286 checks passed
@dd-mergequeue dd-mergequeue bot deleted the automated/omnibus-software/572 branch March 10, 2025 15:50
@github-actions github-actions bot added this to the 7.65.0 milestone Mar 10, 2025
arbll pushed a commit that referenced this pull request Mar 19, 2025
Co-authored-by: FlorentClarret <1266346+FlorentClarret@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-delivery

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant