Conversation
heyronhay
previously approved these changes
Jan 13, 2026
Collaborator
heyronhay
left a comment
heyronhay
left a comment
There was a problem hiding this comment.
Looks good, one suggestion in the comments, but also, we don't log the JWT token anywhere, do we? To prevent it from exposed. I guess this applies to API/APP keys as well.
|
|
||
| destination_auth = {} | ||
| if k := kwargs.get("destination_api_key"): | ||
| # JWT takes precedence over API keys |
Collaborator
There was a problem hiding this comment.
Should we output a message somewhere if JWT and API keys are specified that the JWT overrides it?
Collaborator
Author
There was a problem hiding this comment.
Good idea, added on lines 147-152.
heyronhay
reviewed
Jan 13, 2026
datadog_sync/utils/configuration.py
Outdated
| if (kwargs.get("source_jwt") and kwargs.get("source_api_key")) or ( | ||
| kwargs.get("destination_jwt") and kwargs.get("destination_api_key") | ||
| ): | ||
| logger.warning("Both a JWT and an API key were found.") |
Collaborator
There was a problem hiding this comment.
"Both a JWT and an API key were found." -> "Both a JWT and an API key were found, JWT will take precedence" or something like that
Collaborator
Author
There was a problem hiding this comment.
oops yeah they need to know what is going on, updated
heyronhay
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows forwarding JWTs.
Description of the Change
This allows for using JWTs instead of app/api keys.