Add more logging for JWT debugging#446
Merged
michael-richey merged 6 commits intomainfrom Feb 5, 2026
Merged
Conversation
heyronhay
reviewed
Feb 5, 2026
datadog_sync/utils/custom_client.py
Outdated
Comment on lines
338
to
340
| # Log first and last 10 chars for debugging without exposing the full token | ||
| if jwt and len(jwt) > 30: | ||
| log.info(f"JWT preview: {jwt[:10]}...{jwt[-10:]}") |
Collaborator
There was a problem hiding this comment.
Is this an ok thing to do with JWT? Seems like a lot of chars to emit.
Collaborator
Author
There was a problem hiding this comment.
agreed, i'll trim it down more
heyronhay
previously approved these changes
Feb 5, 2026
heyronhay
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add more logging and provide a way to not send metrics if we're using a JWT (because they require api and app keys)