Resources should be closed in reverse order.#10532
Resources should be closed in reverse order.#10532gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~59393969f7, baseline=1.60.0-SNAPSHOT~d0c3f6e95c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.071 s) : 0, 1070732
Total [baseline] (8.78 s) : 0, 8780469
Agent [candidate] (1.069 s) : 0, 1069230
Total [candidate] (8.754 s) : 0, 8754022
section iast
Agent [baseline] (1.232 s) : 0, 1232242
Total [baseline] (9.387 s) : 0, 9386621
Agent [candidate] (1.237 s) : 0, 1236711
Total [candidate] (9.362 s) : 0, 9362445
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~59393969f7, baseline=1.60.0-SNAPSHOT~d0c3f6e95c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.206 ms) : 0, 1206
crashtracking [candidate] (1.207 ms) : 0, 1207
BytebuddyAgent [baseline] (632.95 ms) : 0, 632950
BytebuddyAgent [candidate] (630.514 ms) : 0, 630514
AgentMeter [baseline] (29.279 ms) : 0, 29279
AgentMeter [candidate] (29.004 ms) : 0, 29004
GlobalTracer [baseline] (259.677 ms) : 0, 259677
GlobalTracer [candidate] (258.758 ms) : 0, 258758
AppSec [baseline] (32.944 ms) : 0, 32944
AppSec [candidate] (33.011 ms) : 0, 33011
Debugger [baseline] (62.397 ms) : 0, 62397
Debugger [candidate] (62.422 ms) : 0, 62422
Remote Config [baseline] (613.091 µs) : 0, 613
Remote Config [candidate] (619.569 µs) : 0, 620
Telemetry [baseline] (12.293 ms) : 0, 12293
Telemetry [candidate] (10.699 ms) : 0, 10699
Flare Poller [baseline] (3.752 ms) : 0, 3752
Flare Poller [candidate] (7.612 ms) : 0, 7612
section iast
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (796.202 ms) : 0, 796202
BytebuddyAgent [candidate] (799.643 ms) : 0, 799643
AgentMeter [baseline] (11.269 ms) : 0, 11269
AgentMeter [candidate] (11.482 ms) : 0, 11482
GlobalTracer [baseline] (248.485 ms) : 0, 248485
GlobalTracer [candidate] (248.94 ms) : 0, 248940
AppSec [baseline] (32.374 ms) : 0, 32374
AppSec [candidate] (34.928 ms) : 0, 34928
Debugger [baseline] (67.83 ms) : 0, 67830
Debugger [candidate] (65.17 ms) : 0, 65170
Remote Config [baseline] (553.981 µs) : 0, 554
Remote Config [candidate] (539.52 µs) : 0, 540
Telemetry [baseline] (8.643 ms) : 0, 8643
Telemetry [candidate] (8.691 ms) : 0, 8691
Flare Poller [baseline] (3.399 ms) : 0, 3399
Flare Poller [candidate] (3.437 ms) : 0, 3437
IAST [baseline] (26.87 ms) : 0, 26870
IAST [candidate] (27.211 ms) : 0, 27211
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~59393969f7, baseline=1.60.0-SNAPSHOT~d0c3f6e95c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.077 s) : 0, 1077216
Total [baseline] (10.971 s) : 0, 10971394
Agent [candidate] (1.073 s) : 0, 1073488
Total [candidate] (10.932 s) : 0, 10931936
section appsec
Agent [baseline] (1.238 s) : 0, 1237514
Total [baseline] (11.013 s) : 0, 11012902
Agent [candidate] (1.239 s) : 0, 1239066
Total [candidate] (11.044 s) : 0, 11044326
section iast
Agent [baseline] (1.248 s) : 0, 1247709
Total [baseline] (11.27 s) : 0, 11270186
Agent [candidate] (1.236 s) : 0, 1235873
Total [candidate] (11.218 s) : 0, 11218428
section profiling
Agent [baseline] (1.19 s) : 0, 1189979
Total [baseline] (10.987 s) : 0, 10986694
Agent [candidate] (1.19 s) : 0, 1189606
Total [candidate] (10.912 s) : 0, 10912424
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~59393969f7, baseline=1.60.0-SNAPSHOT~d0c3f6e95c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (634.76 ms) : 0, 634760
BytebuddyAgent [candidate] (633.441 ms) : 0, 633441
AgentMeter [baseline] (29.387 ms) : 0, 29387
AgentMeter [candidate] (29.157 ms) : 0, 29157
GlobalTracer [baseline] (260.86 ms) : 0, 260860
GlobalTracer [candidate] (259.444 ms) : 0, 259444
AppSec [baseline] (33.404 ms) : 0, 33404
AppSec [candidate] (33.063 ms) : 0, 33063
Debugger [baseline] (62.169 ms) : 0, 62169
Debugger [candidate] (61.65 ms) : 0, 61650
Remote Config [baseline] (639.12 µs) : 0, 639
Remote Config [candidate] (637.414 µs) : 0, 637
Telemetry [baseline] (12.345 ms) : 0, 12345
Telemetry [candidate] (14.06 ms) : 0, 14060
Flare Poller [baseline] (6.943 ms) : 0, 6943
Flare Poller [candidate] (5.338 ms) : 0, 5338
section appsec
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (656.469 ms) : 0, 656469
BytebuddyAgent [candidate] (657.816 ms) : 0, 657816
AgentMeter [baseline] (11.953 ms) : 0, 11953
AgentMeter [candidate] (11.968 ms) : 0, 11968
GlobalTracer [baseline] (258.742 ms) : 0, 258742
GlobalTracer [candidate] (259.106 ms) : 0, 259106
AppSec [baseline] (167.803 ms) : 0, 167803
AppSec [candidate] (167.981 ms) : 0, 167981
Debugger [baseline] (67.276 ms) : 0, 67276
Debugger [candidate] (66.851 ms) : 0, 66851
Remote Config [baseline] (650.941 µs) : 0, 651
Remote Config [candidate] (662.719 µs) : 0, 663
Telemetry [baseline] (9.209 ms) : 0, 9209
Telemetry [candidate] (9.156 ms) : 0, 9156
Flare Poller [baseline] (3.586 ms) : 0, 3586
Flare Poller [candidate] (3.664 ms) : 0, 3664
IAST [baseline] (25.266 ms) : 0, 25266
IAST [candidate] (25.276 ms) : 0, 25276
section iast
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (806.869 ms) : 0, 806869
BytebuddyAgent [candidate] (797.973 ms) : 0, 797973
AgentMeter [baseline] (11.748 ms) : 0, 11748
AgentMeter [candidate] (11.302 ms) : 0, 11302
GlobalTracer [baseline] (250.893 ms) : 0, 250893
GlobalTracer [candidate] (249.44 ms) : 0, 249440
AppSec [baseline] (35.144 ms) : 0, 35144
AppSec [candidate] (34.001 ms) : 0, 34001
Debugger [baseline] (65.916 ms) : 0, 65916
Debugger [candidate] (66.9 ms) : 0, 66900
Remote Config [baseline] (547.962 µs) : 0, 548
Remote Config [candidate] (548.169 µs) : 0, 548
Telemetry [baseline] (8.678 ms) : 0, 8678
Telemetry [candidate] (8.685 ms) : 0, 8685
Flare Poller [baseline] (3.48 ms) : 0, 3480
Flare Poller [candidate] (3.507 ms) : 0, 3507
IAST [baseline] (27.543 ms) : 0, 27543
IAST [candidate] (26.952 ms) : 0, 26952
section profiling
crashtracking [baseline] (1.211 ms) : 0, 1211
crashtracking [candidate] (1.222 ms) : 0, 1222
BytebuddyAgent [baseline] (681.314 ms) : 0, 681314
BytebuddyAgent [candidate] (681.373 ms) : 0, 681373
AgentMeter [baseline] (8.795 ms) : 0, 8795
AgentMeter [candidate] (8.76 ms) : 0, 8760
GlobalTracer [baseline] (216.036 ms) : 0, 216036
GlobalTracer [candidate] (215.781 ms) : 0, 215781
AppSec [baseline] (32.487 ms) : 0, 32487
AppSec [candidate] (32.179 ms) : 0, 32179
Debugger [baseline] (67.82 ms) : 0, 67820
Debugger [candidate] (67.548 ms) : 0, 67548
Remote Config [baseline] (589.785 µs) : 0, 590
Remote Config [candidate] (613.656 µs) : 0, 614
Telemetry [baseline] (8.813 ms) : 0, 8813
Telemetry [candidate] (8.958 ms) : 0, 8958
Flare Poller [baseline] (3.757 ms) : 0, 3757
Flare Poller [candidate] (3.827 ms) : 0, 3827
ProfilingAgent [baseline] (99.189 ms) : 0, 99189
ProfilingAgent [candidate] (99.439 ms) : 0, 99439
Profiling [baseline] (99.765 ms) : 0, 99765
Profiling [candidate] (100.023 ms) : 0, 100023
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~59393969f7, baseline=1.60.0-SNAPSHOT~d0c3f6e95c
dateFormat X
axisFormat %s
section baseline
no_agent (17.695 ms) : 17514, 17875
. : milestone, 17695,
appsec (18.558 ms) : 18371, 18746
. : milestone, 18558,
code_origins (18.406 ms) : 18221, 18592
. : milestone, 18406,
iast (17.693 ms) : 17518, 17869
. : milestone, 17693,
profiling (18.699 ms) : 18512, 18886
. : milestone, 18699,
tracing (17.709 ms) : 17536, 17881
. : milestone, 17709,
section candidate
no_agent (18.339 ms) : 18150, 18529
. : milestone, 18339,
appsec (18.668 ms) : 18478, 18858
. : milestone, 18668,
code_origins (18.036 ms) : 17855, 18217
. : milestone, 18036,
iast (17.927 ms) : 17749, 18105
. : milestone, 17927,
profiling (19.087 ms) : 18897, 19276
. : milestone, 19087,
tracing (17.573 ms) : 17400, 17746
. : milestone, 17573,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~59393969f7, baseline=1.60.0-SNAPSHOT~d0c3f6e95c
dateFormat X
axisFormat %s
section baseline
no_agent (1.193 ms) : 1181, 1204
. : milestone, 1193,
iast (3.242 ms) : 3201, 3283
. : milestone, 3242,
iast_FULL (5.806 ms) : 5748, 5864
. : milestone, 5806,
iast_GLOBAL (3.622 ms) : 3563, 3680
. : milestone, 3622,
profiling (1.957 ms) : 1941, 1974
. : milestone, 1957,
tracing (1.777 ms) : 1763, 1791
. : milestone, 1777,
section candidate
no_agent (1.172 ms) : 1161, 1184
. : milestone, 1172,
iast (3.27 ms) : 3224, 3315
. : milestone, 3270,
iast_FULL (6.11 ms) : 6048, 6173
. : milestone, 6110,
iast_GLOBAL (3.619 ms) : 3550, 3687
. : milestone, 3619,
profiling (2.347 ms) : 2324, 2370
. : milestone, 2347,
tracing (1.826 ms) : 1810, 1841
. : milestone, 1826,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~59393969f7, baseline=1.60.0-SNAPSHOT~d0c3f6e95c
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (3.718 ms) : 3501, 3934
. : milestone, 3718,
iast (2.258 ms) : 2189, 2327
. : milestone, 2258,
iast_GLOBAL (2.303 ms) : 2233, 2372
. : milestone, 2303,
profiling (2.514 ms) : 2350, 2678
. : milestone, 2514,
tracing (2.064 ms) : 2011, 2118
. : milestone, 2064,
section candidate
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.797 ms) : 3576, 4017
. : milestone, 3797,
iast (2.259 ms) : 2190, 2327
. : milestone, 2259,
iast_GLOBAL (2.302 ms) : 2233, 2371
. : milestone, 2302,
profiling (2.506 ms) : 2342, 2670
. : milestone, 2506,
tracing (2.073 ms) : 2019, 2127
. : milestone, 2073,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~59393969f7, baseline=1.60.0-SNAPSHOT~d0c3f6e95c
dateFormat X
axisFormat %s
section baseline
no_agent (15.041 s) : 15041000, 15041000
. : milestone, 15041000,
appsec (14.937 s) : 14937000, 14937000
. : milestone, 14937000,
iast (18.562 s) : 18562000, 18562000
. : milestone, 18562000,
iast_GLOBAL (17.836 s) : 17836000, 17836000
. : milestone, 17836000,
profiling (15.567 s) : 15567000, 15567000
. : milestone, 15567000,
tracing (14.535 s) : 14535000, 14535000
. : milestone, 14535000,
section candidate
no_agent (15.707 s) : 15707000, 15707000
. : milestone, 15707000,
appsec (14.95 s) : 14950000, 14950000
. : milestone, 14950000,
iast (18.033 s) : 18033000, 18033000
. : milestone, 18033000,
iast_GLOBAL (17.616 s) : 17616000, 17616000
. : milestone, 17616000,
profiling (14.864 s) : 14864000, 14864000
. : milestone, 14864000,
tracing (14.546 s) : 14546000, 14546000
. : milestone, 14546000,
|
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
What Does This Do
Trying to fix Redisson test that hanged on CI.
Motivation
Green CI.
Additional Notes
Test hanged on CI with the follwing thread dump:
There is no obvious root cause, but I noticed that:
redisServer -> redissonClient -> lowLevelRedisClient,redissonClient -> lowLevelRedisClient -> redisServer.It is recommended to clear resources in reverse order. That may potentially fix hanged test.