Adjust metrics temporality according to global preference and instrument type#10545
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~0545c2314e, baseline=1.60.0-SNAPSHOT~e34c2fdd84
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1062259
Total [baseline] (10.801 s) : 0, 10801138
Agent [candidate] (1.067 s) : 0, 1067008
Total [candidate] (10.994 s) : 0, 10993998
section appsec
Agent [baseline] (1.247 s) : 0, 1246810
Total [baseline] (11.023 s) : 0, 11023363
Agent [candidate] (1.239 s) : 0, 1239359
Total [candidate] (11.159 s) : 0, 11159296
section iast
Agent [baseline] (1.23 s) : 0, 1229975
Total [baseline] (11.168 s) : 0, 11168057
Agent [candidate] (1.231 s) : 0, 1230518
Total [candidate] (11.159 s) : 0, 11159302
section profiling
Agent [baseline] (1.191 s) : 0, 1191134
Total [baseline] (10.903 s) : 0, 10903016
Agent [candidate] (1.196 s) : 0, 1196016
Total [candidate] (10.986 s) : 0, 10986076
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~0545c2314e, baseline=1.60.0-SNAPSHOT~e34c2fdd84
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.171 ms) : 0, 1171
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (626.946 ms) : 0, 626946
BytebuddyAgent [candidate] (629.101 ms) : 0, 629101
AgentMeter [baseline] (28.805 ms) : 0, 28805
AgentMeter [candidate] (28.931 ms) : 0, 28931
GlobalTracer [baseline] (257.045 ms) : 0, 257045
GlobalTracer [candidate] (257.998 ms) : 0, 257998
AppSec [baseline] (32.813 ms) : 0, 32813
AppSec [candidate] (32.603 ms) : 0, 32603
Debugger [baseline] (62.897 ms) : 0, 62897
Debugger [candidate] (62.01 ms) : 0, 62010
Remote Config [baseline] (622.43 µs) : 0, 622
Remote Config [candidate] (625.218 µs) : 0, 625
Telemetry [baseline] (13.034 ms) : 0, 13034
Telemetry [candidate] (14.57 ms) : 0, 14570
Flare Poller [baseline] (3.76 ms) : 0, 3760
Flare Poller [candidate] (4.617 ms) : 0, 4617
section appsec
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (662.94 ms) : 0, 662940
BytebuddyAgent [candidate] (658.654 ms) : 0, 658654
AgentMeter [baseline] (12.031 ms) : 0, 12031
AgentMeter [candidate] (12.001 ms) : 0, 12001
GlobalTracer [baseline] (260.544 ms) : 0, 260544
GlobalTracer [candidate] (258.61 ms) : 0, 258610
AppSec [baseline] (168.027 ms) : 0, 168027
AppSec [candidate] (167.568 ms) : 0, 167568
Debugger [baseline] (67.721 ms) : 0, 67721
Debugger [candidate] (67.417 ms) : 0, 67417
Remote Config [baseline] (665.499 µs) : 0, 665
Remote Config [candidate] (657.882 µs) : 0, 658
Telemetry [baseline] (9.194 ms) : 0, 9194
Telemetry [candidate] (9.184 ms) : 0, 9184
Flare Poller [baseline] (3.686 ms) : 0, 3686
Flare Poller [candidate] (3.647 ms) : 0, 3647
IAST [baseline] (25.404 ms) : 0, 25404
IAST [candidate] (25.216 ms) : 0, 25216
section iast
crashtracking [baseline] (1.173 ms) : 0, 1173
crashtracking [candidate] (1.174 ms) : 0, 1174
BytebuddyAgent [baseline] (794.325 ms) : 0, 794325
BytebuddyAgent [candidate] (794.967 ms) : 0, 794967
AgentMeter [baseline] (11.239 ms) : 0, 11239
AgentMeter [candidate] (11.21 ms) : 0, 11210
GlobalTracer [baseline] (247.863 ms) : 0, 247863
GlobalTracer [candidate] (248.392 ms) : 0, 248392
AppSec [baseline] (33.723 ms) : 0, 33723
AppSec [candidate] (33.855 ms) : 0, 33855
Debugger [baseline] (66.711 ms) : 0, 66711
Debugger [candidate] (66.25 ms) : 0, 66250
Remote Config [baseline] (542.056 µs) : 0, 542
Remote Config [candidate] (533.91 µs) : 0, 534
Telemetry [baseline] (8.692 ms) : 0, 8692
Telemetry [candidate] (8.608 ms) : 0, 8608
Flare Poller [baseline] (3.509 ms) : 0, 3509
Flare Poller [candidate] (3.494 ms) : 0, 3494
IAST [baseline] (26.943 ms) : 0, 26943
IAST [candidate] (26.931 ms) : 0, 26931
section profiling
crashtracking [baseline] (1.206 ms) : 0, 1206
crashtracking [candidate] (1.217 ms) : 0, 1217
BytebuddyAgent [baseline] (681.929 ms) : 0, 681929
BytebuddyAgent [candidate] (686.211 ms) : 0, 686211
AgentMeter [baseline] (8.78 ms) : 0, 8780
AgentMeter [candidate] (8.761 ms) : 0, 8761
GlobalTracer [baseline] (216.021 ms) : 0, 216021
GlobalTracer [candidate] (216.933 ms) : 0, 216933
AppSec [baseline] (32.489 ms) : 0, 32489
AppSec [candidate] (32.464 ms) : 0, 32464
Debugger [baseline] (67.922 ms) : 0, 67922
Debugger [candidate] (67.618 ms) : 0, 67618
Remote Config [baseline] (597.998 µs) : 0, 598
Remote Config [candidate] (596.7 µs) : 0, 597
Telemetry [baseline] (8.926 ms) : 0, 8926
Telemetry [candidate] (8.822 ms) : 0, 8822
Flare Poller [baseline] (3.788 ms) : 0, 3788
Flare Poller [candidate] (3.77 ms) : 0, 3770
ProfilingAgent [baseline] (99.526 ms) : 0, 99526
ProfilingAgent [candidate] (99.412 ms) : 0, 99412
Profiling [baseline] (100.108 ms) : 0, 100108
Profiling [candidate] (100.003 ms) : 0, 100003
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~0545c2314e, baseline=1.60.0-SNAPSHOT~e34c2fdd84
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1064393
Total [baseline] (8.751 s) : 0, 8751265
Agent [candidate] (1.066 s) : 0, 1065845
Total [candidate] (8.732 s) : 0, 8732153
section iast
Agent [baseline] (1.231 s) : 0, 1230834
Total [baseline] (9.37 s) : 0, 9370175
Agent [candidate] (1.245 s) : 0, 1245448
Total [candidate] (9.406 s) : 0, 9406084
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~0545c2314e, baseline=1.60.0-SNAPSHOT~e34c2fdd84
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.213 ms) : 0, 1213
BytebuddyAgent [baseline] (628.327 ms) : 0, 628327
BytebuddyAgent [candidate] (632.187 ms) : 0, 632187
AgentMeter [baseline] (28.891 ms) : 0, 28891
AgentMeter [candidate] (29.145 ms) : 0, 29145
GlobalTracer [baseline] (257.67 ms) : 0, 257670
GlobalTracer [candidate] (257.947 ms) : 0, 257947
AppSec [baseline] (32.789 ms) : 0, 32789
AppSec [candidate] (32.579 ms) : 0, 32579
Debugger [baseline] (62.83 ms) : 0, 62830
Debugger [candidate] (61.426 ms) : 0, 61426
Remote Config [baseline] (630.429 µs) : 0, 630
Remote Config [candidate] (618.442 µs) : 0, 618
Telemetry [baseline] (10.742 ms) : 0, 10742
Telemetry [candidate] (9.853 ms) : 0, 9853
Flare Poller [baseline] (6.045 ms) : 0, 6045
Flare Poller [candidate] (5.427 ms) : 0, 5427
section iast
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (796.362 ms) : 0, 796362
BytebuddyAgent [candidate] (805.712 ms) : 0, 805712
AgentMeter [baseline] (11.232 ms) : 0, 11232
AgentMeter [candidate] (11.6 ms) : 0, 11600
GlobalTracer [baseline] (247.313 ms) : 0, 247313
GlobalTracer [candidate] (251.324 ms) : 0, 251324
AppSec [baseline] (32.149 ms) : 0, 32149
AppSec [candidate] (31.041 ms) : 0, 31041
Debugger [baseline] (67.56 ms) : 0, 67560
Debugger [candidate] (69.047 ms) : 0, 69047
Remote Config [baseline] (549.223 µs) : 0, 549
Remote Config [candidate] (538.139 µs) : 0, 538
Telemetry [baseline] (8.753 ms) : 0, 8753
Telemetry [candidate] (8.622 ms) : 0, 8622
Flare Poller [baseline] (3.542 ms) : 0, 3542
Flare Poller [candidate] (3.462 ms) : 0, 3462
IAST [baseline] (26.741 ms) : 0, 26741
IAST [candidate] (27.343 ms) : 0, 27343
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 4 performance regressions! Performance is the same for 15 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~0545c2314e, baseline=1.60.0-SNAPSHOT~e34c2fdd84
dateFormat X
axisFormat %s
section baseline
no_agent (1.177 ms) : 1166, 1189
. : milestone, 1177,
iast (3.236 ms) : 3186, 3285
. : milestone, 3236,
iast_FULL (5.756 ms) : 5698, 5813
. : milestone, 5756,
iast_GLOBAL (3.603 ms) : 3539, 3667
. : milestone, 3603,
profiling (2.013 ms) : 1996, 2031
. : milestone, 2013,
tracing (1.81 ms) : 1795, 1825
. : milestone, 1810,
section candidate
no_agent (1.184 ms) : 1172, 1195
. : milestone, 1184,
iast (3.32 ms) : 3274, 3366
. : milestone, 3320,
iast_FULL (5.849 ms) : 5790, 5907
. : milestone, 5849,
iast_GLOBAL (3.485 ms) : 3434, 3535
. : milestone, 3485,
profiling (2.029 ms) : 2011, 2046
. : milestone, 2029,
tracing (1.814 ms) : 1799, 1828
. : milestone, 1814,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~0545c2314e, baseline=1.60.0-SNAPSHOT~e34c2fdd84
dateFormat X
axisFormat %s
section baseline
no_agent (18.255 ms) : 18065, 18446
. : milestone, 18255,
appsec (18.969 ms) : 18774, 19165
. : milestone, 18969,
code_origins (17.478 ms) : 17303, 17653
. : milestone, 17478,
iast (17.881 ms) : 17703, 18060
. : milestone, 17881,
profiling (18.81 ms) : 18621, 18999
. : milestone, 18810,
tracing (17.435 ms) : 17263, 17606
. : milestone, 17435,
section candidate
no_agent (17.524 ms) : 17350, 17698
. : milestone, 17524,
appsec (19.099 ms) : 18907, 19290
. : milestone, 19099,
code_origins (18.715 ms) : 18526, 18903
. : milestone, 18715,
iast (18.016 ms) : 17834, 18198
. : milestone, 18016,
profiling (19.534 ms) : 19338, 19730
. : milestone, 19534,
tracing (18.018 ms) : 17841, 18195
. : milestone, 18018,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~0545c2314e, baseline=1.60.0-SNAPSHOT~e34c2fdd84
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.785 ms) : 3563, 4006
. : milestone, 3785,
iast (2.259 ms) : 2190, 2328
. : milestone, 2259,
iast_GLOBAL (2.297 ms) : 2228, 2367
. : milestone, 2297,
profiling (2.119 ms) : 2062, 2175
. : milestone, 2119,
tracing (2.057 ms) : 2004, 2110
. : milestone, 2057,
section candidate
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (3.751 ms) : 3531, 3971
. : milestone, 3751,
iast (2.256 ms) : 2187, 2325
. : milestone, 2256,
iast_GLOBAL (2.301 ms) : 2232, 2370
. : milestone, 2301,
profiling (2.087 ms) : 2033, 2142
. : milestone, 2087,
tracing (2.066 ms) : 2013, 2120
. : milestone, 2066,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~0545c2314e, baseline=1.60.0-SNAPSHOT~e34c2fdd84
dateFormat X
axisFormat %s
section baseline
no_agent (14.927 s) : 14927000, 14927000
. : milestone, 14927000,
appsec (14.935 s) : 14935000, 14935000
. : milestone, 14935000,
iast (17.797 s) : 17797000, 17797000
. : milestone, 17797000,
iast_GLOBAL (17.946 s) : 17946000, 17946000
. : milestone, 17946000,
profiling (14.868 s) : 14868000, 14868000
. : milestone, 14868000,
tracing (14.722 s) : 14722000, 14722000
. : milestone, 14722000,
section candidate
no_agent (14.849 s) : 14849000, 14849000
. : milestone, 14849000,
appsec (15.14 s) : 15140000, 15140000
. : milestone, 15140000,
iast (17.678 s) : 17678000, 17678000
. : milestone, 17678000,
iast_GLOBAL (17.902 s) : 17902000, 17902000
. : milestone, 17902000,
profiling (15.147 s) : 15147000, 15147000
. : milestone, 15147000,
tracing (14.534 s) : 14534000, 14534000
. : milestone, 14534000,
|
651666d to
5985318
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
This merge request conflicts with another merge request ahead in the queue. The merge requests in front of this one are: |
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
stuart.mcculloch@datadoghq.com unqueued this merge request |
|
/remove |
|
View all feedbacks in Devflow UI.
|
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
Motivation
Compatibility with https://opentelemetry.io/docs/languages/java/configuration/
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: APMAPI-1671