Open
Conversation
As CapturedValue are evaluated through Expression Language, we are dropping types in the process and resulting having boxed primitives captured and serialized into the snapshot. We introduce keeping track of the type in EL values by introducing ValueType enum. This way each EL expression evaluated can return a value that keep the existing type (Object, int, long, double, ...) Also lookup and getMember methods from ValueReferenceResolver are now returning CapturedValue to get the type and be able to transfer it to EL values
Contributor
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (310.843 µs) : 283, 339
. : milestone, 311,
basic (271.014 µs) : 265, 277
. : milestone, 271,
loop (8.948 ms) : 8942, 8953
. : milestone, 8948,
section candidate
noprobe (319.583 µs) : 278, 361
. : milestone, 320,
basic (274.955 µs) : 270, 280
. : milestone, 275,
loop (8.952 ms) : 8947, 8957
. : milestone, 8952,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~0111a8576c, baseline=1.60.0-SNAPSHOT~d8f2599d6f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1067028
Total [baseline] (10.908 s) : 0, 10908235
Agent [candidate] (1.071 s) : 0, 1070608
Total [candidate] (11.021 s) : 0, 11020887
section appsec
Agent [baseline] (1.24 s) : 0, 1240026
Total [baseline] (11.047 s) : 0, 11046923
Agent [candidate] (1.241 s) : 0, 1241381
Total [candidate] (11.094 s) : 0, 11094262
section iast
Agent [baseline] (1.231 s) : 0, 1231023
Total [baseline] (11.289 s) : 0, 11289499
Agent [candidate] (1.24 s) : 0, 1240269
Total [candidate] (11.172 s) : 0, 11172016
section profiling
Agent [baseline] (1.193 s) : 0, 1192975
Total [baseline] (11.117 s) : 0, 11117192
Agent [candidate] (1.194 s) : 0, 1194049
Total [candidate] (11.183 s) : 0, 11183441
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~0111a8576c, baseline=1.60.0-SNAPSHOT~d8f2599d6f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.175 ms) : 0, 1175
crashtracking [candidate] (1.209 ms) : 0, 1209
BytebuddyAgent [baseline] (629.186 ms) : 0, 629186
BytebuddyAgent [candidate] (632.167 ms) : 0, 632167
AgentMeter [baseline] (28.892 ms) : 0, 28892
AgentMeter [candidate] (29.019 ms) : 0, 29019
GlobalTracer [baseline] (258.518 ms) : 0, 258518
GlobalTracer [candidate] (259.277 ms) : 0, 259277
AppSec [baseline] (32.855 ms) : 0, 32855
AppSec [candidate] (32.962 ms) : 0, 32962
Debugger [baseline] (62.787 ms) : 0, 62787
Debugger [candidate] (63.03 ms) : 0, 63030
Remote Config [baseline] (618.264 µs) : 0, 618
Remote Config [candidate] (618.43 µs) : 0, 618
Telemetry [baseline] (12.274 ms) : 0, 12274
Telemetry [candidate] (10.796 ms) : 0, 10796
Flare Poller [baseline] (5.36 ms) : 0, 5360
Flare Poller [candidate] (6.139 ms) : 0, 6139
section appsec
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.172 ms) : 0, 1172
BytebuddyAgent [baseline] (658.928 ms) : 0, 658928
BytebuddyAgent [candidate] (658.523 ms) : 0, 658523
AgentMeter [baseline] (11.873 ms) : 0, 11873
AgentMeter [candidate] (11.884 ms) : 0, 11884
GlobalTracer [baseline] (258.66 ms) : 0, 258660
GlobalTracer [candidate] (258.828 ms) : 0, 258828
IAST [baseline] (25.415 ms) : 0, 25415
IAST [candidate] (25.416 ms) : 0, 25416
AppSec [baseline] (167.87 ms) : 0, 167870
AppSec [candidate] (168.888 ms) : 0, 168888
Debugger [baseline] (67.452 ms) : 0, 67452
Debugger [candidate] (67.089 ms) : 0, 67089
Remote Config [baseline] (651.493 µs) : 0, 651
Remote Config [candidate] (658.65 µs) : 0, 659
Telemetry [baseline] (9.037 ms) : 0, 9037
Telemetry [candidate] (9.871 ms) : 0, 9871
Flare Poller [baseline] (3.691 ms) : 0, 3691
Flare Poller [candidate] (3.74 ms) : 0, 3740
section iast
crashtracking [baseline] (1.18 ms) : 0, 1180
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (795.748 ms) : 0, 795748
BytebuddyAgent [candidate] (801.602 ms) : 0, 801602
AgentMeter [baseline] (11.262 ms) : 0, 11262
AgentMeter [candidate] (11.561 ms) : 0, 11561
GlobalTracer [baseline] (247.779 ms) : 0, 247779
GlobalTracer [candidate] (249.502 ms) : 0, 249502
IAST [baseline] (26.935 ms) : 0, 26935
IAST [candidate] (27.111 ms) : 0, 27111
AppSec [baseline] (33.746 ms) : 0, 33746
AppSec [candidate] (32.127 ms) : 0, 32127
Debugger [baseline] (66.466 ms) : 0, 66466
Debugger [candidate] (68.941 ms) : 0, 68941
Remote Config [baseline] (548.173 µs) : 0, 548
Remote Config [candidate] (546.831 µs) : 0, 547
Telemetry [baseline] (8.739 ms) : 0, 8739
Telemetry [candidate] (8.766 ms) : 0, 8766
Flare Poller [baseline] (3.509 ms) : 0, 3509
Flare Poller [candidate] (3.511 ms) : 0, 3511
section profiling
crashtracking [baseline] (1.217 ms) : 0, 1217
crashtracking [candidate] (1.213 ms) : 0, 1213
BytebuddyAgent [baseline] (682.839 ms) : 0, 682839
BytebuddyAgent [candidate] (684.071 ms) : 0, 684071
AgentMeter [baseline] (8.731 ms) : 0, 8731
AgentMeter [candidate] (8.753 ms) : 0, 8753
GlobalTracer [baseline] (216.269 ms) : 0, 216269
GlobalTracer [candidate] (216.663 ms) : 0, 216663
AppSec [baseline] (32.506 ms) : 0, 32506
AppSec [candidate] (32.505 ms) : 0, 32505
Debugger [baseline] (68.255 ms) : 0, 68255
Debugger [candidate] (67.977 ms) : 0, 67977
Remote Config [baseline] (598.466 µs) : 0, 598
Remote Config [candidate] (598.694 µs) : 0, 599
Telemetry [baseline] (8.882 ms) : 0, 8882
Telemetry [candidate] (8.848 ms) : 0, 8848
Flare Poller [baseline] (3.733 ms) : 0, 3733
Flare Poller [candidate] (3.73 ms) : 0, 3730
ProfilingAgent [baseline] (100.095 ms) : 0, 100095
ProfilingAgent [candidate] (99.706 ms) : 0, 99706
Profiling [baseline] (100.671 ms) : 0, 100671
Profiling [candidate] (100.293 ms) : 0, 100293
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~0111a8576c, baseline=1.60.0-SNAPSHOT~d8f2599d6f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1064816
Total [baseline] (8.77 s) : 0, 8770488
Agent [candidate] (1.066 s) : 0, 1065688
Total [candidate] (8.774 s) : 0, 8774463
section iast
Agent [baseline] (1.234 s) : 0, 1233707
Total [baseline] (9.406 s) : 0, 9406011
Agent [candidate] (1.249 s) : 0, 1249240
Total [candidate] (9.415 s) : 0, 9415147
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~0111a8576c, baseline=1.60.0-SNAPSHOT~d8f2599d6f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (629.089 ms) : 0, 629089
BytebuddyAgent [candidate] (628.572 ms) : 0, 628572
AgentMeter [baseline] (28.972 ms) : 0, 28972
AgentMeter [candidate] (28.817 ms) : 0, 28817
GlobalTracer [baseline] (257.918 ms) : 0, 257918
GlobalTracer [candidate] (258.414 ms) : 0, 258414
AppSec [baseline] (32.817 ms) : 0, 32817
AppSec [candidate] (32.798 ms) : 0, 32798
Debugger [baseline] (61.992 ms) : 0, 61992
Debugger [candidate] (61.193 ms) : 0, 61193
Remote Config [baseline] (610.477 µs) : 0, 610
Remote Config [candidate] (612.584 µs) : 0, 613
Telemetry [baseline] (10.804 ms) : 0, 10804
Telemetry [candidate] (13.33 ms) : 0, 13330
Flare Poller [baseline] (6.142 ms) : 0, 6142
Flare Poller [candidate] (5.44 ms) : 0, 5440
section iast
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.202 ms) : 0, 1202
BytebuddyAgent [baseline] (797.854 ms) : 0, 797854
BytebuddyAgent [candidate] (808.585 ms) : 0, 808585
AgentMeter [baseline] (11.264 ms) : 0, 11264
AgentMeter [candidate] (11.797 ms) : 0, 11797
GlobalTracer [baseline] (248.624 ms) : 0, 248624
GlobalTracer [candidate] (250.733 ms) : 0, 250733
IAST [baseline] (27.095 ms) : 0, 27095
IAST [candidate] (27.343 ms) : 0, 27343
AppSec [baseline] (32.265 ms) : 0, 32265
AppSec [candidate] (33.813 ms) : 0, 33813
Debugger [baseline] (67.57 ms) : 0, 67570
Debugger [candidate] (67.239 ms) : 0, 67239
Remote Config [baseline] (559.706 µs) : 0, 560
Remote Config [candidate] (546.594 µs) : 0, 547
Telemetry [baseline] (8.641 ms) : 0, 8641
Telemetry [candidate] (8.784 ms) : 0, 8784
Flare Poller [baseline] (3.44 ms) : 0, 3440
Flare Poller [candidate] (3.524 ms) : 0, 3524
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 1 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~0111a8576c, baseline=1.60.0-SNAPSHOT~d8f2599d6f
dateFormat X
axisFormat %s
section baseline
no_agent (1.183 ms) : 1171, 1195
. : milestone, 1183,
iast (3.3 ms) : 3256, 3345
. : milestone, 3300,
iast_FULL (5.987 ms) : 5926, 6048
. : milestone, 5987,
iast_GLOBAL (3.738 ms) : 3681, 3794
. : milestone, 3738,
profiling (2.128 ms) : 2108, 2148
. : milestone, 2128,
tracing (1.778 ms) : 1763, 1792
. : milestone, 1778,
section candidate
no_agent (1.191 ms) : 1178, 1204
. : milestone, 1191,
iast (3.431 ms) : 3381, 3480
. : milestone, 3431,
iast_FULL (5.967 ms) : 5907, 6026
. : milestone, 5967,
iast_GLOBAL (3.611 ms) : 3548, 3674
. : milestone, 3611,
profiling (2.259 ms) : 2238, 2280
. : milestone, 2259,
tracing (1.824 ms) : 1809, 1839
. : milestone, 1824,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~0111a8576c, baseline=1.60.0-SNAPSHOT~d8f2599d6f
dateFormat X
axisFormat %s
section baseline
no_agent (18.996 ms) : 18803, 19190
. : milestone, 18996,
appsec (19.437 ms) : 19236, 19637
. : milestone, 19437,
code_origins (17.708 ms) : 17530, 17885
. : milestone, 17708,
iast (17.585 ms) : 17409, 17761
. : milestone, 17585,
profiling (18.645 ms) : 18461, 18830
. : milestone, 18645,
tracing (17.597 ms) : 17426, 17769
. : milestone, 17597,
section candidate
no_agent (17.258 ms) : 17086, 17430
. : milestone, 17258,
appsec (18.955 ms) : 18764, 19145
. : milestone, 18955,
code_origins (17.629 ms) : 17454, 17804
. : milestone, 17629,
iast (17.443 ms) : 17269, 17618
. : milestone, 17443,
profiling (18.829 ms) : 18637, 19022
. : milestone, 18829,
tracing (18.583 ms) : 18394, 18772
. : milestone, 18583,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~0111a8576c, baseline=1.60.0-SNAPSHOT~d8f2599d6f
dateFormat X
axisFormat %s
section baseline
no_agent (1.462 ms) : 1451, 1473
. : milestone, 1462,
appsec (2.502 ms) : 2447, 2557
. : milestone, 2502,
iast (2.243 ms) : 2174, 2311
. : milestone, 2243,
iast_GLOBAL (2.279 ms) : 2210, 2348
. : milestone, 2279,
profiling (2.094 ms) : 2038, 2150
. : milestone, 2094,
tracing (2.052 ms) : 1998, 2105
. : milestone, 2052,
section candidate
no_agent (1.47 ms) : 1458, 1481
. : milestone, 1470,
appsec (2.504 ms) : 2449, 2558
. : milestone, 2504,
iast (2.249 ms) : 2180, 2318
. : milestone, 2249,
iast_GLOBAL (2.277 ms) : 2208, 2346
. : milestone, 2277,
profiling (2.083 ms) : 2027, 2139
. : milestone, 2083,
tracing (2.046 ms) : 1993, 2099
. : milestone, 2046,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~0111a8576c, baseline=1.60.0-SNAPSHOT~d8f2599d6f
dateFormat X
axisFormat %s
section baseline
no_agent (15.299 s) : 15299000, 15299000
. : milestone, 15299000,
appsec (15.098 s) : 15098000, 15098000
. : milestone, 15098000,
iast (18.038 s) : 18038000, 18038000
. : milestone, 18038000,
iast_GLOBAL (17.902 s) : 17902000, 17902000
. : milestone, 17902000,
profiling (15.106 s) : 15106000, 15106000
. : milestone, 15106000,
tracing (14.817 s) : 14817000, 14817000
. : milestone, 14817000,
section candidate
no_agent (15.586 s) : 15586000, 15586000
. : milestone, 15586000,
appsec (15.208 s) : 15208000, 15208000
. : milestone, 15208000,
iast (18.026 s) : 18026000, 18026000
. : milestone, 18026000,
iast_GLOBAL (17.877 s) : 17877000, 17877000
. : milestone, 17877000,
profiling (14.949 s) : 14949000, 14949000
. : milestone, 14949000,
tracing (15.393 s) : 15393000, 15393000
. : milestone, 15393000,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
As CapturedValue are evaluated through Expression Language, we are dropping types in the process and resulting having boxed primitives captured and serialized into the snapshot.
We introduce keeping track of the type in EL values by introducing ValueType enum. This way each EL expression evaluated can return a value that keep the existing type (Object, int, long, double, ...) Also lookup and getMember methods from ValueReferenceResolver are now returning CapturedValue to get the type and be able to transfer it to EL values
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [DEBUG-5148]