Skip to content

Conversation

@vpellan
Copy link
Contributor

@vpellan vpellan commented Dec 2, 2025

What does this PR do?

This will send all the DD configs through telemetry, including the configs with lower precedence. This means that a config set through env var and code will be reported three times, (default, env_var and code) with the corresponding values. To differentiate the one with the highest precedence, we send a seq_id, and the highest seq_id is the currently active config.

Motivation

Additional Notes

Waiting for a new release of libdd-telemetry

@vpellan vpellan changed the title [APMAPI-1693] Enhanced config reporting feat(config_visibility): [APMAPI-1693] Enhanced config reporting Dec 2, 2025
@vpellan vpellan force-pushed the vpellan/enhanced-config-reporting branch from 1b96c81 to e225e0f Compare December 2, 2025 16:54
@vpellan vpellan force-pushed the vpellan/enhanced-config-reporting branch from 5bc7112 to 0e5510d Compare December 5, 2025 15:45
@vpellan vpellan marked this pull request as ready for review December 5, 2025 15:46
@vpellan vpellan requested a review from a team as a code owner December 5, 2025 15:46
@vpellan vpellan force-pushed the vpellan/enhanced-config-reporting branch 2 times, most recently from 8aa25b7 to 3561e0b Compare January 14, 2026 09:41
@bantonsson bantonsson changed the title feat(config_visibility): [APMAPI-1693] Enhanced config reporting feat(config_visibility): enhanced config reporting [APMAPI-1693] Jan 14, 2026
Copy link
Collaborator

@bantonsson bantonsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the code has become a bit convoluted. I would like to know if it's ok to have gaps in the sequence ids, like this:

[
  { "name": "logs_injection_enabled", "origin": "default", "value": false, "seq_id": 1 },
  { "name": "logs_injection_enabled", "origin": "env_var", "value": true, "seq_id": 3 },
  { "name": "logs_injection_enabled", "origin": "code", "value": true, "seq_id": 4 }
]

Then the code could be simplified by using the ConfigSourceOrigin as the sequence id.

@vpellan vpellan force-pushed the vpellan/enhanced-config-reporting branch 2 times, most recently from f43ac4f to e49a088 Compare January 15, 2026 13:35
@vpellan
Copy link
Contributor Author

vpellan commented Jan 15, 2026

Hey @bantonsson , thanks for your review! I applied your changes on 6f39ebe. I was so focused on getting the sequence id in the correct order that I did not realised that there could be gaps between them... The answer is yes and it does simplify the code.

@vpellan vpellan force-pushed the vpellan/enhanced-config-reporting branch from e49a088 to 9c97488 Compare January 15, 2026 13:42
@vpellan vpellan requested a review from bantonsson January 15, 2026 13:43
@vpellan vpellan force-pushed the vpellan/enhanced-config-reporting branch from 9c97488 to 7c7b37b Compare February 5, 2026 13:21
@vpellan vpellan merged commit 133d26b into main Feb 5, 2026
24 checks passed
@vpellan vpellan deleted the vpellan/enhanced-config-reporting branch February 5, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants