-
Notifications
You must be signed in to change notification settings - Fork 3
feat(config_visibility): enhanced config reporting [APMAPI-1693] #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1b96c81 to
e225e0f
Compare
5bc7112 to
0e5510d
Compare
8aa25b7 to
3561e0b
Compare
bantonsson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the code has become a bit convoluted. I would like to know if it's ok to have gaps in the sequence ids, like this:
[
{ "name": "logs_injection_enabled", "origin": "default", "value": false, "seq_id": 1 },
{ "name": "logs_injection_enabled", "origin": "env_var", "value": true, "seq_id": 3 },
{ "name": "logs_injection_enabled", "origin": "code", "value": true, "seq_id": 4 }
]
Then the code could be simplified by using the ConfigSourceOrigin as the sequence id.
f43ac4f to
e49a088
Compare
|
Hey @bantonsson , thanks for your review! I applied your changes on 6f39ebe. I was so focused on getting the sequence id in the correct order that I did not realised that there could be gaps between them... The answer is yes and it does simplify the code. |
e49a088 to
9c97488
Compare
…and DD_DOGSTATSD_URL
-apply suggestions Co-authored-by: bjorn.antonsson <bjorn.antonsson@datadoghq.com>
9c97488 to
7c7b37b
Compare
What does this PR do?
This will send all the DD configs through telemetry, including the configs with lower precedence. This means that a config set through env var and code will be reported three times, (default, env_var and code) with the corresponding values. To differentiate the one with the highest precedence, we send a seq_id, and the highest seq_id is the currently active config.
Motivation
Additional Notes
Waiting for a new release of libdd-telemetry