Adds DisposeAsync to IDogStatsd Interface for Tracer Usage#224
Open
link04 wants to merge 4 commits intoDataDog:masterfrom
Open
Adds DisposeAsync to IDogStatsd Interface for Tracer Usage#224link04 wants to merge 4 commits intoDataDog:masterfrom
link04 wants to merge 4 commits intoDataDog:masterfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 60c5e0d27a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exposes
DisposeAsync()on the publicIDogStatsdinterface, allowing callers to await disposal and avoid sync-over-async patterns.Changes
IDogStatsdnow hasDisposeAsync()DogStatsdServiceimplements itMotivation
With
DisposeAsync(), callers can now doawait dogstatsd.DisposeAsync();instead of blocking withdogstatsd.Dispose();.Testing
DisposeAsync_CanBeCalledMultipleTimes- verifies concurrent dispose calls don't deadlockDisposeAsync_Completes_WithInFlightMetrics- verifies disposal completes even with ongoing metric trafficManual benchmark
CompareSyncVsAsync_UnderStarvation(run with[Explicit]test) shows ~3x faster disposal under thread pool pressure(mostly added to showcase a difference).