ServiceCheck metric does not respect configured prefix#94
Open
rpopovych wants to merge 2 commits intoDataDog:masterfrom
Open
ServiceCheck metric does not respect configured prefix#94rpopovych wants to merge 2 commits intoDataDog:masterfrom
rpopovych wants to merge 2 commits intoDataDog:masterfrom
Conversation
rpopovych
changed the title
rpopovych
changed the title
Member
|
Adding a note here that this change would be breaking and we'll need to bump the major version if it gets included |
Contributor
|
@rpopovych: Thank you for the PR. Unfortunately, our other DogStatsD clients do not use prefix for I will track this request in our internal backlog to make a change in all our clients. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing #91