Conversation
Scan-Build Report
Bug Summary
Reports
|
||||||||||||||||||||||||||||||||||||
CI Test ResultsRun: #21754553104 | Commit:
Status Overview
Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled Summary
Updated: 2026-02-06 15:01:12 UTC |
jbachorik
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Mitigating
VMMethod::id()crashes in latest release.Motivation:
Currently, crash tracker report does not provide sufficient information to identify the root cause. While we are waiting for DataDog/dd-trace-java #10544 Preserve the function relative address when parsing a crash to gather more information to solve the mysteries, let's provide a mitigation for this crash.
Other than
SafeAccesss insideVMMethod::id()method,VMMethod*can be invalid, e.g. points to unmapped memory, let's validates the memory before the access.Additional Notes:
How to test the change?:
-Regular tests
-New gtest to verify new
SafeAccess::isReadable()For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!