Skip to content

Conversation

@szegedi
Copy link

@szegedi szegedi commented Feb 9, 2026

What does this PR do?:
Removes caching/reuse of PersistentContextPtr instances.

Motivation:
This was always a speculative attempt to reduce native memory fragmentation. The standard library can be expected to do some of this itself, so we should not be doing this, especially since it is also removed in #255 and it seems to be causing issues (see #7355).

Additional Notes:
#255 also contains this, but we can roll it out as a quicker measure to try to eliminate the memory issue. An advantage of rolling this out separately is that #255 requires some changes in dd-trace-js too, while this as a standalone change does not.

@szegedi szegedi added the semver-patch Bug or security fixes, mainly label Feb 9, 2026
@pr-commenter
Copy link

pr-commenter bot commented Feb 9, 2026

Benchmarks

Benchmark execution time: 2026-02-09 12:25:49

Comparing candidate commit 2e18962 in PR branch szegedi/no-dead-list with baseline commit eb9eabd in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 92 metrics, 28 unstable metrics.

@github-actions
Copy link

github-actions bot commented Feb 9, 2026

Overall package size

Self size: 1.77 MB
Deduped: 2.16 MB
No deduping: 2.16 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | p-limit | 3.1.0 | 7.75 kB | 13.78 kB | | delay | 5.0.0 | 11.17 kB | 11.17 kB | | node-gyp-build | 3.9.0 | 8.81 kB | 8.81 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@szegedi szegedi force-pushed the szegedi/no-dead-list branch from ee05b8d to 42bb2d4 Compare February 9, 2026 11:27
@szegedi szegedi marked this pull request as ready for review February 9, 2026 11:57
@szegedi szegedi force-pushed the szegedi/no-dead-list branch from 42bb2d4 to e9cd659 Compare February 9, 2026 12:16
@szegedi szegedi force-pushed the szegedi/no-dead-list branch from e9cd659 to f1af6c9 Compare February 9, 2026 12:17
Copy link

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we can try this, I do not believe this is the actual cause of the report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-patch Bug or security fixes, mainly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants