-
Notifications
You must be signed in to change notification settings - Fork 83
#725 dev #727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
#725 dev #727
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,4 +37,4 @@ enabled:1b // switch on subscribercutoff | |
|
|
||
| \d .servers | ||
| CONNECTIONS,:`segmentedtickerplant | ||
| CONNECTIONSFROMDISCOVERY:1b | ||
| CONNECTIONSFROMDISCOVERY:DISCOVERYCONNECT | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need to change this? This won't change behaviour in case of community edition (it was already 0b), but will change behaviour in non-community edition, making it 1b
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like it was 1b before, even though it looks like it was 0b in the PR discussion: https://github.com/DataIntellectTech/TorQ/blob/master/config/settings/segmentedchainedtickerplant.q#L40
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. interesting, github acting strange in that case, this comment applies here too: DataIntellectTech/TorQ-Finance-Starter-Pack#122 (comment) |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should leave these as defaulting to
0b.DISCOVERYCONNECTis not defined in this file, so this enforces that that variable must be defined in config, which we don't wantThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the assumption that
config/settings/default.qwould always be loaded in to every process before any other config, but if this is incorrect then I'll change to 0bThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not exactly incorrect, but the reason we have all these
@[value;...]lines is so that none of these values have to be set in config - obviously people can (& often should) change default configs etc., so just makes more sense to have sensible defaults in the code that doesn't depend on configThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah makes sense, cheers