Adding di.cache module #76
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
we should probably have tests for setmaxinidiv and setmaxsize, including validating that the max sizes are respected by execute
Comment on lines
+9
to
+10
| true,0,0,q,100~ maxindividual,1,, Check maxindividual configed correctly by function | ||
| true,0,0,q,100~ maxsize,1,, Check maxindividual configed correctly by function |
Member
There was a problem hiding this comment.
this is OK, but we should make sure that when we actually call execute, if result is too large it won't get cached, and that things get evicted from cache as necessary etc.
Contributor
There was a problem hiding this comment.
I see the difference there, will update now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commiting code from Adam Beck and Lewis Cooley