Responsive startRender and EndRender with multiple TDs#17
Open
jerrybrown5 wants to merge 3 commits intoDataTables:masterfrom
Open
Responsive startRender and EndRender with multiple TDs#17jerrybrown5 wants to merge 3 commits intoDataTables:masterfrom
jerrybrown5 wants to merge 3 commits intoDataTables:masterfrom
Conversation
- fix: allow startRender and EndRender to have multiple columns without interfering with Responsive
+ mimic display of corresponding header columns
+ leave unchanged logic when there is only one td
- fix: dont wrap a tr > td around a tr
- not addressed: not checking colspans and not populating colspan of last td when there are more than one td and number of tds is less than visible responsive cols
…ive-startRender-&-endRender Update dataTables.rowGroup.js (more responsive startRender & endRender)
- fix: allow startRender and EndRender to have multiple columns playing more nicely with Responsive
+ mimic display of corresponding header columns
+ leave unchanged logic when there is only one td
- fix: dont wrap a tr > td around a tr
- not addressed: not checking colspans and not populating colspan of last td when there are more than one td and number of tds is less than visible responsive cols
Collaborator
|
Thanks for this! Are you happy for this to be included under the MIT license? |
Author
|
Of course. Anything else I submit I'm ok with that as well. Thanks for the great tool! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: allow startRender and EndRender to have multiple columns playing more nicely with Responsive
fix: dont wrap a tr > td around a tr
not addressed: not checking colspans and not populating colspan of last td when there are more than one td and number of tds is less than visible responsive cols