Add enum parser for enums that are mapped to chars#61
Open
philhd wants to merge 1 commit intoDavidArno:masterfrom
Open
Add enum parser for enums that are mapped to chars#61philhd wants to merge 1 commit intoDavidArno:masterfrom
philhd wants to merge 1 commit intoDavidArno:masterfrom
Conversation
Owner
|
Hi, Just a quick note to let you know I've seen this, but not yet looked at it. I'm in the process of merging in features for a 4.0 release. So at some stage (I'd like to think in the next week, but summer holidays may push this out until early September), I'll take a look and see if it's good to add to that release. Thanks, |
Author
|
Great! Thanks for getting back to me.
…-Phil
On Mon, Aug 6, 2018 at 3:14 AM David Arno ***@***.***> wrote:
Hi,
Just a quick note to let you know I've seen this, but not yet looked at
it. I'm in the process of merging in features for a 4.0 release. So at some
stage (I'd like to think in the next week, but summer holidays may push
this out until early September), I'll take a look and see if it's good to
add to that release.
Thanks,
David.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#61 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABOsZjzsZQvygZHt6zALHvVZt6ZpDTX9ks5uN-zegaJpZM4VuI6V>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this would be a useful addition because of the way that enums mapped to chars are handled. If you think this would be good to have in the library I can clean it up and match style etc.