Skip to content

Conversation

@Davidyz
Copy link
Owner

@Davidyz Davidyz commented Jun 28, 2025

Deduplication doesn't play very nicely with summarysation due to the following:

  1. it prevents the LLM requesting the same results without summarisation;
  2. the summariser doesn't always produce the summary. Its system prompt instructs it to optimise the summary based on the query. When deduplication is on, the main chat LLM won't be able to see these.

Therefore, I'm disabling deduplication when summarisation is enabled.

@Davidyz Davidyz added bug Something isn't working fix labels Jun 28, 2025
@codecov
Copy link

codecov bot commented Jun 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.75%. Comparing base (99709a9) to head (e7a6074).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #223   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files          21       21           
  Lines        1627     1627           
=======================================
  Hits         1623     1623           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Davidyz Davidyz force-pushed the feat/summary_deduplication branch from 5bc4001 to e7a6074 Compare June 28, 2025 07:59
@Davidyz Davidyz merged commit 03a7020 into main Jun 28, 2025
13 checks passed
@Davidyz Davidyz deleted the feat/summary_deduplication branch June 28, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant